From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP9O-0000cR-I0 for qemu-devel@nongnu.org; Tue, 22 Sep 2015 11:06:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeP9J-0000u8-0B for qemu-devel@nongnu.org; Tue, 22 Sep 2015 11:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP9I-0000tw-RE for qemu-devel@nongnu.org; Tue, 22 Sep 2015 11:06:28 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 756D5461D7 for ; Tue, 22 Sep 2015 15:06:28 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-71.ams2.redhat.com [10.36.112.71]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8MF6IoA027175 for ; Tue, 22 Sep 2015 11:06:27 -0400 From: Paolo Bonzini Date: Tue, 22 Sep 2015 17:05:28 +0200 Message-Id: <1442934371-12567-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1442934371-12567-1-git-send-email-pbonzini@redhat.com> References: <1442934371-12567-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 05/48] checkpatch: do not recommend qemu_strtok over strtok List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org If anything it should recommend strtok_r! Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 574334b..b6d71ea 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2463,8 +2463,8 @@ sub process { WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); } -# recommend qemu_strto* over strto* - if ($line =~ /\b(strto.*?)\s*\(/) { +# recommend qemu_strto* over strto* for numeric conversions + if ($line =~ /\b(strto[^k].*?)\s*\(/) { WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); } # check for module_init(), use category-specific init macros explicitly please -- 2.5.0