From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeWYG-0000FS-K9 for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeWYB-0003Ar-NR for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:00:44 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeWYB-0003AX-Hg for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:00:39 -0400 Received: by wicge5 with SMTP id ge5so183039401wic.0 for ; Tue, 22 Sep 2015 16:00:39 -0700 (PDT) From: Eric Auger Date: Wed, 23 Sep 2015 00:00:30 +0100 Message-Id: <1442962830-7437-3-git-send-email-eric.auger@linaro.org> In-Reply-To: <1442962830-7437-1-git-send-email-eric.auger@linaro.org> References: <1442962830-7437-1-git-send-email-eric.auger@linaro.org> Subject: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, alex.williamson@redhat.com Cc: peter.maydell@linaro.org, christoffer.dall@linaro.org, patches@linaro.org In irqfd mode, current code attempts to set a resamplefd whatever the type of the IRQ. For an edge-sensitive IRQ this attempt fails and as a consequence the whole irqfd setup fails and we fall back to the slow mode. This patch bypasses the resamplefd setting for non level-sentive IRQs. Signed-off-by: Eric Auger --- hw/vfio/platform.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index 38eaccf..2c91650 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -352,6 +352,10 @@ static int vfio_set_resample_eventfd(VFIOINTp *intp) int argsz, ret; int32_t *pfd; + if (!(intp->flags & VFIO_IRQ_INFO_AUTOMASKED)) { + return 0; + } + argsz = sizeof(*irq_set) + sizeof(*pfd); irq_set = g_malloc0(argsz); irq_set->argsz = argsz; -- 1.8.3.2