From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
agraf@suse.de, qemu-ppc@nongnu.org,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 01/36] spapr: Provide an error message when migration fails due to htab_shift mismatch
Date: Wed, 23 Sep 2015 11:55:03 +1000 [thread overview]
Message-ID: <1442973338-17771-2-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1442973338-17771-1-git-send-email-david@gibson.dropbear.id.au>
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Include an error message when migration fails due to mismatch in
htab_shift values at source and target. This should provide a bit more
verbose message in addition to the current migration failure message
that reads like:
qemu-system-ppc64: error while loading state for instance 0x0 of device 'spapr/htab'
After this patch, the failure message will look like this:
qemu-system-ppc64: htab_shift mismatch: source 29 target 24
qemu-system-ppc64: error while loading state for instance 0x0 of device 'spapr/htab'
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 05926a3..dd58eb4 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1329,6 +1329,8 @@ static int htab_load(QEMUFile *f, void *opaque, int version_id)
if (section_hdr) {
/* First section, just the hash shift */
if (spapr->htab_shift != section_hdr) {
+ error_report("htab_shift mismatch: source %d target %d",
+ section_hdr, spapr->htab_shift);
return -EINVAL;
}
return 0;
--
2.4.3
next prev parent reply other threads:[~2015-09-23 1:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 1:55 [Qemu-devel] [PULL 00/36] spapr-next queue 20150923 David Gibson
2015-09-23 1:55 ` David Gibson [this message]
2015-09-23 1:55 ` [Qemu-devel] [PULL 02/36] spapr: Create pseries-2.5 machine David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 03/36] spapr: Add /ibm,partition-name David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 04/36] spapr: Add /rtas/ibm, change-msix-capable David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 05/36] spapr: Make ibm, change-msi respect 3 return values David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 06/36] spapr: SPLPAR Characteristics David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 07/36] spapr: add dumpdtb support David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 08/36] spapr_drc: Fix potential undefined behaviour David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 09/36] ppc/spapr: Use qemu_log_mask() for hcall_dprintf() David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 10/36] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 11/36] sPAPR: Introduce rtas_ldq() David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 12/36] pseries: define coldplugged devices as "configured" David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 13/36] pseries: Update SLOF firmware image to qemu-slof-20150813 David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 14/36] pseries: Fix incorrect calculation of threads per socket for chip-id David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 15/36] spapr: Enable in-kernel H_SET_MODE handling David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 16/36] spapr_pci: fix device tree props for MSI/MSI-X David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 17/36] spapr_drc: don't allow 'empty' DRCs to be unisolated or allocated David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 18/36] spapr: Initialize hotplug memory address space David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 19/36] spapr_drc: use RTAS return codes for methods called by RTAS David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 20/36] spapr: Don't use QOM [*] syntax for DR connectors David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 21/36] spapr: Use QEMU limit for maximum CPUs number David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 22/36] spapr: Add LMB DR connectors David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 23/36] spapr: Support ibm, dynamic-reconfiguration-memory David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 24/36] spapr: Make hash table size a factor of maxram_size David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 25/36] spapr: Memory hotplug support David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 26/36] spapr: Don't allow memory hotplug to memory less nodes David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 27/36] spapr: Provide better error message when slots exceed max allowed David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 28/36] spapr: Populate ibm, associativity-lookup-arrays correctly for non-NUMA David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 29/36] spapr: Revert to memory@XXXX representation for non-hotplugged memory David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 30/36] spapr: Support hotplug by specifying DRC count David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 31/36] spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 32/36] spapr: Fix default NUMA node allocation for threads David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 33/36] ppc/spapr: Fix buffer overflow in spapr_populate_drconf_memory() David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 34/36] ppc/spapr: Implement H_RANDOM hypercall in QEMU David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 35/36] sPAPR: Revert don't enable EEH on emulated PCI devices David Gibson
2015-09-23 1:55 ` [Qemu-devel] [PULL 36/36] sPAPR: Enable EEH on VFIO PCI device only David Gibson
2015-09-23 17:18 ` [Qemu-devel] [PULL 00/36] spapr-next queue 20150923 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442973338-17771-2-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).