From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4sB-0000zE-Nx for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf4sA-0007Ay-UW for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:39:35 -0400 Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:35534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf4sA-0007Au-RL for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:39:34 -0400 Received: by qgt47 with SMTP id 47so41373511qgt.2 for ; Thu, 24 Sep 2015 04:39:34 -0700 (PDT) Sender: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= From: marcandre.lureau@redhat.com Date: Thu, 24 Sep 2015 13:37:39 +0200 Message-Id: <1443094669-4144-38-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v4 37/47] contrib: remove unnecessary strdup() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- contrib/ivshmem-client/main.c | 2 +- contrib/ivshmem-server/main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c index 5d85ae7..bd7cbfc 100644 --- a/contrib/ivshmem-client/main.c +++ b/contrib/ivshmem-client/main.c @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, char *argv[]) break; case 'S': /* unix_sock_path */ - args->unix_sock_path = strdup(optarg); + args->unix_sock_path = optarg; break; default: diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index cd8d9ed..71e87ea 100644 --- a/contrib/ivshmem-server/main.c +++ b/contrib/ivshmem-server/main.c @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[]) break; case 'p': /* pid_file */ - args->pid_file = strdup(optarg); + args->pid_file = optarg; break; case 'S': /* unix_socket_path */ - args->unix_socket_path = strdup(optarg); + args->unix_socket_path = optarg; break; case 'm': /* shm_path */ - args->shm_path = strdup(optarg); + args->shm_path = optarg; break; case 'l': /* shm_size */ -- 2.4.3