From: Shraddha Barke <shraddha.6596@gmail.com>
To: kvm@vger.kernel.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Shraddha Barke <shraddha.6596@gmail.com>
Subject: [Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable
Date: Fri, 25 Sep 2015 14:07:57 +0530 [thread overview]
Message-ID: <1443170278-9318-2-git-send-email-shraddha.6596@gmail.com> (raw)
In-Reply-To: <1443170278-9318-1-git-send-email-shraddha.6596@gmail.com>
Compress lines and remove the variable ret.
Change made using Coccinelle script
@@
expression ret;
@@
- if (ret) return ret;
- return 0;
+ return ret;
@@
local idexpression ret;
expression e;
@@
- ret = e;
- return ret;
+ return e;
@@
type T; identifier i;
@@
- T i;
... when != i
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
hw/timer/tusb6010.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c
index 459c748..ba01050 100644
--- a/hw/timer/tusb6010.c
+++ b/hw/timer/tusb6010.c
@@ -321,7 +321,6 @@ static uint32_t tusb_async_readw(void *opaque, hwaddr addr)
TUSBState *s = (TUSBState *) opaque;
int offset = addr & 0xfff;
int epnum;
- uint32_t ret;
switch (offset) {
case TUSB_DEV_CONF:
@@ -338,12 +337,11 @@ static uint32_t tusb_async_readw(void *opaque, hwaddr addr)
return 0x00; /* TODO */
case TUSB_DEV_OTG_STAT:
- ret = s->otg_status;
#if 0
if (!(s->prcm_mngmt & TUSB_PRCM_MNGMT_OTG_VBUS_DET_EN))
ret &= ~TUSB_DEV_OTG_STAT_VBUS_VALID;
#endif
- return ret;
+ return s->otg_status;
case TUSB_DEV_OTG_TIMER:
return s->otg_timer_val;
--
2.1.4
next prev parent reply other threads:[~2015-09-25 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:37 [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable Shraddha Barke
2015-09-25 8:37 ` Shraddha Barke [this message]
2015-09-25 21:35 ` [Qemu-devel] [PATCH 2/3] Hw: timer: " Peter Maydell
2015-09-25 8:37 ` [Qemu-devel] [PATCH 3/3] Target-ppc: " Shraddha Barke
2015-09-26 16:15 ` Eric Blake
2015-09-28 10:56 ` Paolo Bonzini
2015-10-03 16:50 ` Michael Tokarev
2015-10-03 16:50 ` [Qemu-devel] [PATCH 1/3] Target-microblaze: " Michael Tokarev
2015-10-05 5:18 ` Markus Armbruster
2015-10-05 7:18 ` Michael Tokarev
2015-10-05 7:53 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443170278-9318-2-git-send-email-shraddha.6596@gmail.com \
--to=shraddha.6596@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).