From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfOWI-0005al-PJ for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:38:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfOWH-0003Jw-US for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:38:18 -0400 From: Shraddha Barke Date: Fri, 25 Sep 2015 14:07:57 +0530 Message-Id: <1443170278-9318-2-git-send-email-shraddha.6596@gmail.com> In-Reply-To: <1443170278-9318-1-git-send-email-shraddha.6596@gmail.com> References: <1443170278-9318-1-git-send-email-shraddha.6596@gmail.com> Subject: [Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org, qemu-trivial@nongnu.org, Michael Tokarev Cc: Paolo Bonzini , qemu-devel , Shraddha Barke Compress lines and remove the variable ret. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shraddha Barke --- hw/timer/tusb6010.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c index 459c748..ba01050 100644 --- a/hw/timer/tusb6010.c +++ b/hw/timer/tusb6010.c @@ -321,7 +321,6 @@ static uint32_t tusb_async_readw(void *opaque, hwaddr addr) TUSBState *s = (TUSBState *) opaque; int offset = addr & 0xfff; int epnum; - uint32_t ret; switch (offset) { case TUSB_DEV_CONF: @@ -338,12 +337,11 @@ static uint32_t tusb_async_readw(void *opaque, hwaddr addr) return 0x00; /* TODO */ case TUSB_DEV_OTG_STAT: - ret = s->otg_status; #if 0 if (!(s->prcm_mngmt & TUSB_PRCM_MNGMT_OTG_VBUS_DET_EN)) ret &= ~TUSB_DEV_OTG_STAT_VBUS_VALID; #endif - return ret; + return s->otg_status; case TUSB_DEV_OTG_TIMER: return s->otg_timer_val; -- 2.1.4