qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Bruce Rogers" <brogers@suse.com>, "Lin Ma" <lma@suse.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 7/7] string-input-visitor: Use qemu_strto[u]ll()
Date: Fri, 25 Sep 2015 14:39:48 +0200	[thread overview]
Message-ID: <1443184788-18859-8-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1443184788-18859-1-git-send-email-afaerber@suse.de>

Switch from strtoll() and strtoull() to qemu_strtoll() and
qemu_strtoull(), as recommended by checkpatch.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 qapi/string-input-visitor.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index cf81f85..859ef96 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -39,10 +39,11 @@ static void free_range(void *range, void *dummy)
 
 static void parse_str(StringInputVisitor *siv, bool u64, Error **errp)
 {
-    char *str = (char *) siv->string;
+    const char *str = siv->string;
     long long start, end;
     Range *cur;
-    char *endptr;
+    const char *endptr;
+    int ret;
 
     if (siv->ranges) {
         return;
@@ -51,11 +52,11 @@ static void parse_str(StringInputVisitor *siv, bool u64, Error **errp)
     do {
         errno = 0;
         if (u64) {
-            start = strtoull(str, &endptr, 0);
+            ret = qemu_strtoull(str, &endptr, 0, (unsigned long long *)&start);
         } else {
-            start = strtoll(str, &endptr, 0);
+            ret = qemu_strtoll(str, &endptr, 0, &start);
         }
-        if (errno == 0 && endptr > str) {
+        if (ret == 0 && endptr > str) {
             if (*endptr == '\0') {
                 cur = g_malloc0(sizeof(*cur));
                 cur->begin = start;
@@ -67,8 +68,8 @@ static void parse_str(StringInputVisitor *siv, bool u64, Error **errp)
             } else if (*endptr == '-' && !u64) {
                 str = endptr + 1;
                 errno = 0;
-                end = strtoll(str, &endptr, 0);
-                if (errno == 0 && endptr > str && start <= end &&
+                ret = qemu_strtoll(str, &endptr, 0, &end);
+                if (ret == 0 && endptr > str && start <= end &&
                     (start > INT64_MAX - 65536 ||
                      end < start + 65536)) {
                     if (*endptr == '\0') {
-- 
2.1.4

      parent reply	other threads:[~2015-09-25 12:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 12:39 [Qemu-devel] [PATCH 0/7] visitor: Fix uint64 parsing for scsi-disk wwn Andreas Färber
2015-09-25 12:39 ` [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing Andreas Färber
2015-09-25 14:49   ` Eric Blake
2015-11-11 19:26     ` Andreas Färber
2015-09-30 13:19   ` Markus Armbruster
2015-09-30 13:23     ` Andreas Färber
2015-09-30 13:48       ` Eric Blake
2015-09-30 13:47     ` Eric Blake
2015-09-25 12:39 ` [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case Andreas Färber
2015-09-25 14:50   ` Eric Blake
2015-09-25 12:39 ` [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test Andreas Färber
2015-09-25 14:55   ` Eric Blake
2015-09-25 12:39 ` [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests Andreas Färber
2015-09-25 14:58   ` Eric Blake
2015-09-25 15:01   ` Daniel P. Berrange
2015-11-11 19:52     ` Andreas Färber
2015-09-25 12:39 ` [Qemu-devel] [PATCH 5/7] tests: Add scsi-disk test Andreas Färber
2015-09-25 12:39 ` [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature Andreas Färber
2015-09-25 12:42   ` Paolo Bonzini
2015-09-25 12:44     ` Andreas Färber
2015-09-25 12:56       ` Paolo Bonzini
2015-09-25 13:27         ` Andreas Färber
2015-09-25 13:47           ` Paolo Bonzini
2015-09-25 14:59   ` Eric Blake
2015-09-25 12:39 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443184788-18859-8-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=brogers@suse.com \
    --cc=lma@suse.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).