From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfTYZ-0007lp-C1 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfTYT-00082k-IB for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:00:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfTYS-0007tx-Kl for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:00:52 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id A42DC92486 for ; Fri, 25 Sep 2015 14:00:50 +0000 (UTC) From: Markus Armbruster Date: Fri, 25 Sep 2015 16:00:42 +0200 Message-Id: <1443189647-11417-2-git-send-email-armbru@redhat.com> In-Reply-To: <1443189647-11417-1-git-send-email-armbru@redhat.com> References: <1443189647-11417-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com, lersek@redhat.com Make the variables holding the event QDict instead of QObject. Signed-off-by: Markus Armbruster --- monitor.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/monitor.c b/monitor.c index d0edb3b..2cbb2d9 100644 --- a/monitor.c +++ b/monitor.c @@ -185,7 +185,7 @@ typedef struct MonitorQAPIEventState { int64_t rate; /* Minimum time (in ns) between two events */ int64_t last; /* QEMU_CLOCK_REALTIME value at last emission */ QEMUTimer *timer; /* Timer for handling delayed events */ - QObject *data; /* Event pending delayed dispatch */ + QDict *qdict; /* Event pending delayed dispatch */ } MonitorQAPIEventState; struct Monitor { @@ -445,14 +445,14 @@ static MonitorQAPIEventState monitor_qapi_event_state[QAPI_EVENT_MAX]; * Emits the event to every monitor instance, @event is only used for trace * Called with monitor_lock held. */ -static void monitor_qapi_event_emit(QAPIEvent event, QObject *data) +static void monitor_qapi_event_emit(QAPIEvent event, QDict *qdict) { Monitor *mon; - trace_monitor_protocol_event_emit(event, data); + trace_monitor_protocol_event_emit(event, qdict); QLIST_FOREACH(mon, &mon_list, entry) { if (monitor_is_qmp(mon) && mon->qmp.in_command_mode) { - monitor_json_emitter(mon, data); + monitor_json_emitter(mon, QOBJECT(qdict)); } } } @@ -462,7 +462,7 @@ static void monitor_qapi_event_emit(QAPIEvent event, QObject *data) * applying any rate limiting if required. */ static void -monitor_qapi_event_queue(QAPIEvent event, QDict *data, Error **errp) +monitor_qapi_event_queue(QAPIEvent event, QDict *qdict, Error **errp) { MonitorQAPIEventState *evstate; assert(event < QAPI_EVENT_MAX); @@ -470,7 +470,7 @@ monitor_qapi_event_queue(QAPIEvent event, QDict *data, Error **errp) evstate = &(monitor_qapi_event_state[event]); trace_monitor_protocol_event_queue(event, - data, + qdict, evstate->rate, evstate->last, now); @@ -478,26 +478,26 @@ monitor_qapi_event_queue(QAPIEvent event, QDict *data, Error **errp) /* Rate limit of 0 indicates no throttling */ qemu_mutex_lock(&monitor_lock); if (!evstate->rate) { - monitor_qapi_event_emit(event, QOBJECT(data)); + monitor_qapi_event_emit(event, qdict); evstate->last = now; } else { int64_t delta = now - evstate->last; - if (evstate->data || + if (evstate->qdict || delta < evstate->rate) { /* If there's an existing event pending, replace * it with the new event, otherwise schedule a * timer for delayed emission */ - if (evstate->data) { - qobject_decref(evstate->data); + if (evstate->qdict) { + QDECREF(evstate->qdict); } else { int64_t then = evstate->last + evstate->rate; timer_mod_ns(evstate->timer, then); } - evstate->data = QOBJECT(data); - qobject_incref(evstate->data); + evstate->qdict = qdict; + QINCREF(evstate->qdict); } else { - monitor_qapi_event_emit(event, QOBJECT(data)); + monitor_qapi_event_emit(event, qdict); evstate->last = now; } } @@ -514,14 +514,14 @@ static void monitor_qapi_event_handler(void *opaque) int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); trace_monitor_protocol_event_handler(evstate->event, - evstate->data, + evstate->qdict, evstate->last, now); qemu_mutex_lock(&monitor_lock); - if (evstate->data) { - monitor_qapi_event_emit(evstate->event, evstate->data); - qobject_decref(evstate->data); - evstate->data = NULL; + if (evstate->qdict) { + monitor_qapi_event_emit(evstate->event, evstate->qdict); + QDECREF(evstate->qdict); + evstate->qdict = NULL; } evstate->last = now; qemu_mutex_unlock(&monitor_lock); @@ -548,7 +548,7 @@ monitor_qapi_event_throttle(QAPIEvent event, int64_t rate) assert(rate * SCALE_MS <= INT64_MAX); evstate->rate = rate * SCALE_MS; evstate->last = 0; - evstate->data = NULL; + evstate->qdict = NULL; evstate->timer = timer_new(QEMU_CLOCK_REALTIME, SCALE_MS, monitor_qapi_event_handler, -- 2.4.3