From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfU6w-0000aa-GK for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:36:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfU6v-0007SJ-LY for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:36:30 -0400 From: Shraddha Barke Date: Fri, 25 Sep 2015 20:06:03 +0530 Message-Id: <1443191763-3445-2-git-send-email-shraddha.6596@gmail.com> In-Reply-To: <1443191763-3445-1-git-send-email-shraddha.6596@gmail.com> References: <1443191763-3445-1-git-send-email-shraddha.6596@gmail.com> Subject: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , qemu-trivial@nongnu.org, Michael Tokarev Cc: qemu-devel , Shraddha Barke Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shraddha Barke --- hw/timer/m48t59.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index 8ab683d..b3df8f9 100644 --- a/hw/timer/m48t59.c +++ b/hw/timer/m48t59.c @@ -590,10 +590,8 @@ static void nvram_writel (void *opaque, hwaddr addr, uint32_t value) static uint32_t nvram_readb (void *opaque, hwaddr addr) { M48t59State *NVRAM = opaque; - uint32_t retval; - retval = m48t59_read(NVRAM, addr); - return retval; + return m48t59_read(NVRAM, addr); } static uint32_t nvram_readw (void *opaque, hwaddr addr) -- 2.1.4