qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Subject: [Qemu-devel] [PULL 49/52] i386: interrupt poll processing
Date: Fri, 25 Sep 2015 18:51:37 +0200	[thread overview]
Message-ID: <1443199900-5003-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1443199900-5003-1-git-send-email-pbonzini@redhat.com>

From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>

This patch updates x86_cpu_exec_interrupt function.
It can process two interrupt request at a time (poll and another one).
This makes its execution non-deterministic. Determinism is requred
for recorded icount execution.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Message-Id: <20150917162410.8676.13042.stgit@PASHA-ISP.def.inno>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target-i386/seg_helper.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
index 1a3a2e7..1cbe559 100644
--- a/target-i386/seg_helper.c
+++ b/target-i386/seg_helper.c
@@ -1321,6 +1321,9 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
     if (interrupt_request & CPU_INTERRUPT_POLL) {
         cs->interrupt_request &= ~CPU_INTERRUPT_POLL;
         apic_poll_irq(cpu->apic_state);
+        /* Don't process multiple interrupt requests in a single call.
+           This is required to make icount-driven execution deterministic. */
+        return true;
     }
 #endif
     if (interrupt_request & CPU_INTERRUPT_SIPI) {
-- 
2.5.0

  parent reply	other threads:[~2015-09-25 16:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 16:51 [Qemu-devel] [PULL v2 00/52] Misc changes for 2015-09-25 Paolo Bonzini
2015-09-25 16:51 ` [Qemu-devel] [PULL 25/52] hmp: added io apic dump state Paolo Bonzini
2015-09-25 16:51 ` [Qemu-devel] [PULL 48/52] i386: partial revert of interrupt poll fix Paolo Bonzini
2015-09-25 16:51 ` Paolo Bonzini [this message]
2015-09-25 16:51 ` [Qemu-devel] [PULL 50/52] typedef: add typedef for QemuOpts Paolo Bonzini
2015-09-28  6:23   ` Pavel Dovgaluk
2015-09-25 16:51 ` [Qemu-devel] [PULL 51/52] docs: describe the QEMU build system structure / design Paolo Bonzini
2015-09-25 16:51 ` [Qemu-devel] [PULL 52/52] doc: Refresh URLs in the qemu-tech documentation Paolo Bonzini
2015-09-25 22:11 ` [Qemu-devel] [PULL v2 00/52] Misc changes for 2015-09-25 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443199900-5003-4-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).