From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfWDx-0002q6-ME for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfWDu-0007Lx-Hv for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:51:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfWDu-0007Li-D9 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:51:50 -0400 From: Paolo Bonzini Date: Fri, 25 Sep 2015 18:51:37 +0200 Message-Id: <1443199900-5003-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1443199900-5003-1-git-send-email-pbonzini@redhat.com> References: <1443199900-5003-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 49/52] i386: interrupt poll processing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Pavel Dovgalyuk From: Pavel Dovgalyuk This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162410.8676.13042.stgit@PASHA-ISP.def.inno> Signed-off-by: Paolo Bonzini --- target-i386/seg_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 1a3a2e7..1cbe559 100644 --- a/target-i386/seg_helper.c +++ b/target-i386/seg_helper.c @@ -1321,6 +1321,9 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request) if (interrupt_request & CPU_INTERRUPT_POLL) { cs->interrupt_request &= ~CPU_INTERRUPT_POLL; apic_poll_irq(cpu->apic_state); + /* Don't process multiple interrupt requests in a single call. + This is required to make icount-driven execution deterministic. */ + return true; } #endif if (interrupt_request & CPU_INTERRUPT_SIPI) { -- 2.5.0