* [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute
@ 2014-03-16 18:07 Stefan Weil
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2014-03-16 18:07 UTC (permalink / raw)
To: qemu-trivial; +Cc: Peter Maydell, qemu-devel, Stefan Weil
This fixes a warning from the static code analysis (smatch).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-arm/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/machine.c b/target-arm/machine.c
index 8f9e7d4..7ced87a 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -88,7 +88,7 @@ static bool m_needed(void *opaque)
return arm_feature(env, ARM_FEATURE_M);
}
-const VMStateDescription vmstate_m = {
+static const VMStateDescription vmstate_m = {
.name = "cpu/m",
.version_id = 1,
.minimum_version_id = 1,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute
@ 2015-09-25 20:42 Stefan Weil
2015-09-25 21:58 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2015-09-25 20:42 UTC (permalink / raw)
To: QEMU Developer; +Cc: QEMU Trivial, Peter Maydell, Stefan Weil
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 8367997..584f6df 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -5194,7 +5194,7 @@ void switch_mode(CPUARMState *env, int mode)
* BIT IRQ IMO Non-secure Secure
* EL3 FIQ RW FMO EL0 EL1 EL2 EL3 EL0 EL1 EL2 EL3
*/
-const int8_t target_el_table[2][2][2][2][2][4] = {
+static const int8_t target_el_table[2][2][2][2][2][4] = {
{{{{/* 0 0 0 0 */{ 1, 1, 2, -1 },{ 3, -1, -1, 3 },},
{/* 0 0 0 1 */{ 2, 2, 2, -1 },{ 3, -1, -1, 3 },},},
{{/* 0 0 1 0 */{ 1, 1, 2, -1 },{ 3, -1, -1, 3 },},
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute
2015-09-25 20:42 [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute Stefan Weil
@ 2015-09-25 21:58 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-09-25 21:58 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Trivial, QEMU Developer
On 25 September 2015 at 13:42, Stefan Weil <sw@weilnetz.de> wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> target-arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 8367997..584f6df 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5194,7 +5194,7 @@ void switch_mode(CPUARMState *env, int mode)
> * BIT IRQ IMO Non-secure Secure
> * EL3 FIQ RW FMO EL0 EL1 EL2 EL3 EL0 EL1 EL2 EL3
> */
> -const int8_t target_el_table[2][2][2][2][2][4] = {
> +static const int8_t target_el_table[2][2][2][2][2][4] = {
> {{{{/* 0 0 0 0 */{ 1, 1, 2, -1 },{ 3, -1, -1, 3 },},
> {/* 0 0 0 1 */{ 2, 2, 2, -1 },{ 3, -1, -1, 3 },},},
> {{/* 0 0 1 0 */{ 1, 1, 2, -1 },{ 3, -1, -1, 3 },},
> --
> 2.1.4
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-25 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-25 20:42 [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute Stefan Weil
2015-09-25 21:58 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2014-03-16 18:07 Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).