qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: gang.chen.5i5j@gmail.com
To: peter.maydell@linaro.org, rth@twiddle.net
Cc: cmetcalf@ezchip.com, qemu-devel@nongnu.org,
	xili_gchen_5257@hotmail.com, Chen Gang <gang.chen.5i5j@gmail.com>
Subject: [Qemu-devel] [PATCH] target-tilegx: Let v1addi call its own implementation
Date: Sun, 27 Sep 2015 19:36:30 +0800	[thread overview]
Message-ID: <1443353790-4977-1-git-send-email-gang.chen.5i5j@gmail.com> (raw)

From: Chen Gang <gang.chen.5i5j@gmail.com>

Original implementation let v1addi instruction call v1cmpeqi.

It will cause gcc testsuite fail: the relate test is for mm instruction,
tilegx qemu implement mm instruction correctly, but its 'v1addi' causes
test abort.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 target-tilegx/translate.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
index 969c66e..86da6b5 100644
--- a/target-tilegx/translate.c
+++ b/target-tilegx/translate.c
@@ -1477,6 +1477,11 @@ static TileExcp gen_rri_opcode(DisasContext *dc, unsigned opext,
         break;
     case OE_IM(V1ADDI, X0):
     case OE_IM(V1ADDI, X1):
+        t0 = tcg_const_tl(V1_IMM(imm));
+        gen_helper_v1add(tdest, tsrca, t0);
+        tcg_temp_free(t0);
+        mnemonic = "v1addi";
+        break;
     case OE_IM(V1CMPEQI, X0):
     case OE_IM(V1CMPEQI, X1):
         tcg_gen_xori_tl(tdest, tsrca, V1_IMM(imm));
-- 
1.9.3

                 reply	other threads:[~2015-09-27 11:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443353790-4977-1-git-send-email-gang.chen.5i5j@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=cmetcalf@ezchip.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=xili_gchen_5257@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).