From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgcHO-0007px-NI for qemu-devel@nongnu.org; Mon, 28 Sep 2015 13:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgcHL-00054z-Gq for qemu-devel@nongnu.org; Mon, 28 Sep 2015 13:31:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgcHL-00054v-CZ for qemu-devel@nongnu.org; Mon, 28 Sep 2015 13:31:55 -0400 From: Eduardo Habkost Date: Mon, 28 Sep 2015 14:31:35 -0300 Message-Id: <1443461499-5843-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1443461499-5843-1-git-send-email-ehabkost@redhat.com> References: <1443461499-5843-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 3/7] target-i386: Enable "check" mode by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson Current default behavior of QEMU is to silently disable features that are not supported by the host when a CPU model is requested in the command-line. This means that in addition to risking breaking guest ABI by default, we are silent about it. I would like to enable "enforce" by default, but this can easily break existing production systems because of the way libvirt makes assumptions about CPU models today (this will change in the future, once QEMU provide a proper interface for checking if a CPU model is runnable). But there's no reason we should be silent about it. So, change target-i386 to enable "check" mode by default so at least we have some warning printed to stderr (and hopefully logged somewhere) when QEMU disables a feature that is not supported by the host system. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index bd411b9..3d39e8b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3116,7 +3116,7 @@ static Property x86_cpu_properties[] = { DEFINE_PROP_BOOL("hv-vapic", X86CPU, hyperv_vapic, false), DEFINE_PROP_BOOL("hv-time", X86CPU, hyperv_time, false), DEFINE_PROP_BOOL("hv-crash", X86CPU, hyperv_crash, false), - DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, false), + DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, true), DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false), DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true), DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0), -- 2.1.0