From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 6/7] target-i386: Make check_hw_breakpoints static
Date: Mon, 28 Sep 2015 14:31:38 -0300 [thread overview]
Message-ID: <1443461499-5843-7-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1443461499-5843-1-git-send-email-ehabkost@redhat.com>
From: Richard Henderson <rth@twiddle.net>
The function is now only used from within a single file.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/bpt_helper.c | 2 +-
target-i386/cpu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c
index 6f6537d..c071c24 100644
--- a/target-i386/bpt_helper.c
+++ b/target-i386/bpt_helper.c
@@ -79,7 +79,7 @@ void hw_breakpoint_remove(CPUX86State *env, int index)
}
}
-bool check_hw_breakpoints(CPUX86State *env, bool force_dr6_update)
+static bool check_hw_breakpoints(CPUX86State *env, bool force_dr6_update)
{
target_ulong dr6;
int reg;
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index dc7654d..92426dc 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -1154,7 +1154,6 @@ static inline int hw_breakpoint_len(unsigned long dr7, int index)
void hw_breakpoint_insert(CPUX86State *env, int index);
void hw_breakpoint_remove(CPUX86State *env, int index);
-bool check_hw_breakpoints(CPUX86State *env, bool force_dr6_update);
void breakpoint_handler(CPUState *cs);
/* will be suppressed */
--
2.1.0
next prev parent reply other threads:[~2015-09-28 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 17:31 [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28 Eduardo Habkost
2015-09-28 17:31 ` [Qemu-devel] [PULL 1/7] cpu: Introduce X86CPUTopoInfo structure for argument simplification Eduardo Habkost
2015-09-28 17:31 ` [Qemu-devel] [PULL 2/7] vl: Add another sanity check to smp_parse() function Eduardo Habkost
2015-09-28 17:31 ` [Qemu-devel] [PULL 3/7] target-i386: Enable "check" mode by default Eduardo Habkost
2015-09-28 17:31 ` [Qemu-devel] [PULL 4/7] target-i386: Convert kvm_default_*features to property/value pairs Eduardo Habkost
2015-09-28 17:31 ` [Qemu-devel] [PULL 5/7] target-i386: Move breakpoint related functions to new file Eduardo Habkost
2015-09-28 17:31 ` Eduardo Habkost [this message]
2015-09-28 17:31 ` [Qemu-devel] [PULL 7/7] target-i386: get/put MSR_TSC_AUX across reset and migration Eduardo Habkost
2015-09-29 11:28 ` [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28 Peter Maydell
2015-09-29 11:29 ` Peter Maydell
2015-09-29 18:22 ` Eduardo Habkost
2015-09-29 19:21 ` Peter Maydell
2015-09-29 19:42 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443461499-5843-7-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).