From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33968)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zgs9I-0006AN-Tf
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:28:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zgs9E-0002WE-Rz
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:28:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59439)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zgs9E-0002WA-MC
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:28:36 -0400
Message-ID: <1443522513.21557.18.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 29 Sep 2015 12:28:33 +0200
In-Reply-To: <1443206217-6255-1-git-send-email-pl@kamp.de>
References: <1443206217-6255-1-git-send-email-pl@kamp.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no
	client is connected
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org

  Hi,

> -    graphic_hw_update(vd->dcl.con);
> +    if (first_client) {
> +        /* set/restore the correct surface in the VNC server */
> +        console_select(0);

Nah, that has unwanted side effects.

Pushed some patches to git://git.kraxel.org/qemu rebase/ui-vnc-next,
could you have a look?

thanks,
  Gerd