From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguM5-0005xr-H4 for qemu-devel@nongnu.org; Tue, 29 Sep 2015 08:50:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZguM2-0007i9-Au for qemu-devel@nongnu.org; Tue, 29 Sep 2015 08:50:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguM2-0007i3-5U for qemu-devel@nongnu.org; Tue, 29 Sep 2015 08:49:58 -0400 Message-ID: <1443530995.21557.24.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 29 Sep 2015 14:49:55 +0200 In-Reply-To: References: <1443206217-6255-1-git-send-email-pl@kamp.de> <1443522513.21557.18.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu-devel@nongnu.org On Di, 2015-09-29 at 14:41 +0200, Peter Lieven wrote: > > Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann : > > > > Hi, > > > >> - graphic_hw_update(vd->dcl.con); > >> + if (first_client) { > >> + /* set/restore the correct surface in the VNC server */ > >> + console_select(0); > > > > Nah, that has unwanted side effects. > > okay, ill try to respin without this hack. > > > > > Pushed some patches to git://git.kraxel.org/qemu rebase/ui-vnc-next, > > could you have a look? > > if you mean the RFC patches on the list I already send a bunch of comments on them. It's updated, taking your comments in account, reworking the server surface code so we can free it without clients, also added qio_buffer_shrink() but added no calls yet. cheers, Gerd