From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh3H2-00049e-6Y for qemu-devel@nongnu.org; Tue, 29 Sep 2015 18:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zh3Gz-0001IK-9R for qemu-devel@nongnu.org; Tue, 29 Sep 2015 18:21:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh3Gz-0001IG-52 for qemu-devel@nongnu.org; Tue, 29 Sep 2015 18:21:21 -0400 From: Eric Blake Date: Tue, 29 Sep 2015 16:21:00 -0600 Message-Id: <1443565276-4535-3-git-send-email-eblake@redhat.com> In-Reply-To: <1443565276-4535-1-git-send-email-eblake@redhat.com> References: <1443565276-4535-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v7 02/18] qapi: Improve 'include' error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Roth , marcandre.lureau@redhat.com, armbru@redhat.com, ehabkost@redhat.com Use of '"...%s" % include' to print non-strings can lead to ugly messages, such as this (if the .json change is applied without the qapi.py change): Expected a file name (string), got: OrderedDict() Better is to just omit the actual non-string value in the message. Signed-off-by: Eric Blake --- v6: hoist earlier in series (was 6/46), tweak wording of message --- scripts/qapi.py | 3 +-- tests/qapi-schema/include-non-file.err | 2 +- tests/qapi-schema/include-non-file.json | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 06478bb..362e007 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -132,8 +132,7 @@ class QAPISchemaParser(object): include = expr["include"] if not isinstance(include, str): raise QAPIExprError(expr_info, - 'Expected a file name (string), got: %s' - % include) + "Value of 'include' must be a string") incl_abs_fname = os.path.join(os.path.dirname(abs_fname), include) # catch inclusion cycle diff --git a/tests/qapi-schema/include-non-file.err b/tests/qapi-schema/include-non-file.err index 9658c78..faae1ea 100644 --- a/tests/qapi-schema/include-non-file.err +++ b/tests/qapi-schema/include-non-file.err @@ -1 +1 @@ -tests/qapi-schema/include-non-file.json:1: Expected a file name (string), got: ['foo', 'bar'] +tests/qapi-schema/include-non-file.json:1: Value of 'include' must be a string diff --git a/tests/qapi-schema/include-non-file.json b/tests/qapi-schema/include-non-file.json index cd43c3f..4711aa4 100644 --- a/tests/qapi-schema/include-non-file.json +++ b/tests/qapi-schema/include-non-file.json @@ -1 +1 @@ -{ 'include': [ 'foo', 'bar' ] } +{ 'include': {} } -- 2.4.3