From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhs0l-0003kO-NE for qemu-devel@nongnu.org; Fri, 02 Oct 2015 00:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zhs0k-0006YE-AM for qemu-devel@nongnu.org; Fri, 02 Oct 2015 00:31:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhs0k-0006Y3-4h for qemu-devel@nongnu.org; Fri, 02 Oct 2015 00:31:58 -0400 From: Eric Blake Date: Thu, 1 Oct 2015 22:31:44 -0600 Message-Id: <1443760312-656-5-git-send-email-eblake@redhat.com> In-Reply-To: <1443760312-656-1-git-send-email-eblake@redhat.com> References: <1443760312-656-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v6 04/12] qapi: Create simple union type member earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Roth , marcandre.lureau@redhat.com, armbru@redhat.com, ehabkost@redhat.com For simple unions, we were creating the implicit 'type' tag member during the QAPISchemaObjectTypeVariants constructor. This is different from every other implicit QAPISchemaEntity object, which get created by QAPISchema methods. Hoist the creation to the caller, and pass the entity rather than the string name, so that we have the nice property that no entities are created as a side effect within a different entity. A later patch will then have an easier time of associating location info with each entity creation. No change to generated code. Signed-off-by: Eric Blake --- v6: New patch --- scripts/qapi.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 15640b6..255001a 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1010,18 +1010,16 @@ class QAPISchemaObjectTypeMember(object): class QAPISchemaObjectTypeVariants(object): - def __init__(self, tag_name, tag_enum, variants): + def __init__(self, tag_name, tag_member, variants): assert tag_name is None or isinstance(tag_name, str) - assert tag_enum is None or isinstance(tag_enum, str) + assert (tag_member is None or + isinstance(tag_member, QAPISchemaObjectTypeMember)) for v in variants: assert isinstance(v, QAPISchemaObjectTypeVariant) self.tag_name = tag_name if tag_name: - assert not tag_enum - self.tag_member = None - else: - self.tag_member = QAPISchemaObjectTypeMember('type', tag_enum, - False) + assert tag_member is None + self.tag_member = tag_member self.variants = variants def check(self, schema, members, seen): @@ -1226,8 +1224,9 @@ class QAPISchema(object): return QAPISchemaObjectTypeVariant(case, typ) def _make_tag_enum(self, type_name, variants): - return self._make_implicit_enum_type(type_name, - [v.name for v in variants]) + typ = self._make_implicit_enum_type(type_name, + [v.name for v in variants]) + return QAPISchemaObjectTypeMember('type', typ, False) def _def_union_type(self, expr, info): name = expr['union'] -- 2.4.3