From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZhvPD-0008RP-Bu
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 04:09:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZhvP7-0005LS-Ky
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 04:09:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56073)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZhvP7-0005LL-FK
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 04:09:21 -0400
Message-ID: <1443773357.14636.6.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 02 Oct 2015 10:09:17 +0200
In-Reply-To: <560D5057.6010308@redhat.com>
References: <1443701677-13629-1-git-send-email-markmb@redhat.com>
	<1443701819-13855-1-git-send-email-markmb@redhat.com>
	<1443701819-13855-7-git-send-email-markmb@redhat.com>
	<560D5057.6010308@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg
 DMA interface bootable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Drew <drjones@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, Kevin O'Connor <kevin@koconnor.net>, Marc =?ISO-8859-1?Q?Mar=ED?= <markmb@redhat.com>

> - read four bytes from under the fw_cfg selector QEMU_CFG_KERNEL_SIZE
>   (0x0008),
> - if it is zero,    return -1 --> no kernel boot requested,
> - if it is nonzero, return  0 --> which means "top priority".
> 
> In other words, I agree with:
> 
> > -    option_rom[nb_option_roms].bootindex = 0;
> > +    option_rom[nb_option_roms].bootindex = 1;

Hmm.  That makes the boot order undefined for "qemu -kernel foo -device
virtio-blk,drive=bar,bootindex=1" when using an old seabios.  I don't
think this is a good idea.

cheers,
  Gerd