qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/5] raw-win32: Fix write request error handling
Date: Fri,  2 Oct 2015 14:50:54 +0200	[thread overview]
Message-ID: <1443790258-23305-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1443790258-23305-1-git-send-email-kwolf@redhat.com>

aio_worker() wrote the return code to the wrong variable.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Tested-by: Guangmu Zhu <guangmuzhu@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 block/raw-win32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/raw-win32.c b/block/raw-win32.c
index 68f2338..b562c94 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -119,9 +119,9 @@ static int aio_worker(void *arg)
     case QEMU_AIO_WRITE:
         count = handle_aiocb_rw(aiocb);
         if (count == aiocb->aio_nbytes) {
-            count = 0;
+            ret = 0;
         } else {
-            count = -EINVAL;
+            ret = -EINVAL;
         }
         break;
     case QEMU_AIO_FLUSH:
-- 
1.8.3.1

  reply	other threads:[~2015-10-02 12:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 12:50 [Qemu-devel] [PULL 0/5] Block layer patches Kevin Wolf
2015-10-02 12:50 ` Kevin Wolf [this message]
2015-10-02 12:50 ` [Qemu-devel] [PULL 2/5] tests: Fix test 049 fallout from improved HMP error messages Kevin Wolf
2015-10-02 12:50 ` [Qemu-devel] [PULL 3/5] iotests: Fix test 128 for password-less sudo Kevin Wolf
2015-10-02 12:50 ` [Qemu-devel] [PULL 4/5] block: disable I/O limits at the beginning of bdrv_close() Kevin Wolf
2015-10-02 12:50 ` [Qemu-devel] [PULL 5/5] block/raw-posix: Open file descriptor O_RDWR to work around glibc posix_fallocate emulation issue Kevin Wolf
2015-10-02 15:03 ` [Qemu-devel] [PULL 0/5] Block layer patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443790258-23305-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).