qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 00/10] Fix device introspection regressions
Date: Fri,  2 Oct 2015 19:20:31 +0200	[thread overview]
Message-ID: <1443806441-23519-1-git-send-email-armbru@redhat.com> (raw)

QMP command device-list-properties regressed in 2.1: it can crash or
leave dangling pointers behind.

-device FOO,help regressed in 2.2: it no longer works for
non-pluggable devices.  I tried to fix that some time ago[*], but my
fix failed review.  This is my second, more comprehensive try.

PATCH 1-3 fix one class of bugs involved in the regressions, PATCH 4-5
are libqtest preliminaries, PATCH 6 adds tests to demonstrate the
remaining bugs, PATCH 7-9 fix them to a degree (see PATCH 8 for
limitations), and PATCH 10 cleans up.

The following changes since commit ff770b07f34d28b79013a83989bd6c85f8f16b2f:

  Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2015-10-02 11:01:18 +0100)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-02

for you to fetch changes up to e927162a6fa2fa6144de9d1d11cc9448a2143671:

  Revert "qdev: Use qdev_get_device_class() for -device <type>,help" (2015-10-02 16:45:53 +0200)

----------------------------------------------------------------
Fix device introspection regressions

----------------------------------------------------------------
Markus Armbruster (7):
      tests: Fix how qom-test is run
      libqtest: Clean up unused QTestState member sigact_old
      libqtest: New hmp() & friends
      device-introspect-test: New, covering device introspection
      qmp: Fix device-list-properties not to crash for abstract device
      qdev: Protect device-list-properties against broken devices
      Revert "qdev: Use qdev_get_device_class() for -device <type>,help"

Paolo Bonzini (3):
      memory: allow destroying a non-empty MemoryRegion
      hw: do not pass NULL to memory_region_init from instance_init
      macio: move DBDMA_init from instance_init to realize

 hw/arm/allwinner-a10.c         |   6 ++
 hw/arm/digic.c                 |   6 ++
 hw/arm/fsl-imx25.c             |   6 ++
 hw/arm/fsl-imx31.c             |   6 ++
 hw/arm/pxa2xx.c                |   2 +-
 hw/arm/xlnx-zynqmp.c           |   6 ++
 hw/display/cg3.c               |   4 +-
 hw/display/tcx.c               |   2 +-
 hw/misc/arm_integrator_debug.c |   2 +-
 hw/misc/macio/cuda.c           |   2 +-
 hw/misc/macio/macio.c          |  14 ++---
 hw/pci-host/versatile.c        |  11 ++++
 hw/pcmcia/pxa2xx.c             |   6 +-
 hw/s390x/event-facility.c      |   3 +
 hw/s390x/sclp.c                |   3 +
 include/hw/qdev-core.h         |  13 +++++
 memory.c                       |  17 +++++-
 qdev-monitor.c                 |   9 ++-
 qmp.c                          |  11 ++++
 target-alpha/cpu.c             |   7 +++
 target-arm/cpu.c               |  11 ++++
 target-cris/cpu.c              |   7 +++
 target-i386/cpu.c              |   8 +++
 target-lm32/cpu.c              |   7 +++
 target-m68k/cpu.c              |   7 +++
 target-microblaze/cpu.c        |   6 ++
 target-mips/cpu.c              |   7 +++
 target-moxie/cpu.c             |   7 +++
 target-openrisc/cpu.c          |   7 +++
 target-ppc/kvm.c               |   4 ++
 target-s390x/cpu.c             |   7 +++
 target-sh4/cpu.c               |   7 +++
 target-sparc/cpu.c             |   7 +++
 target-tilegx/cpu.c            |   7 +++
 target-tricore/cpu.c           |   6 ++
 target-unicore32/cpu.c         |   7 +++
 target-xtensa/cpu.c            |   7 +++
 tests/Makefile                 |  20 ++++---
 tests/device-introspect-test.c | 124 +++++++++++++++++++++++++++++++++++++++++
 tests/drive_del-test.c         |  22 ++------
 tests/ide-test.c               |   8 +--
 tests/libqtest.c               |  38 ++++++++++++-
 tests/libqtest.h               |  33 +++++++++++
 43 files changed, 449 insertions(+), 51 deletions(-)
 create mode 100644 tests/device-introspect-test.c

-- 
2.4.3

             reply	other threads:[~2015-10-02 17:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 17:20 Markus Armbruster [this message]
2015-10-02 17:20 ` [Qemu-devel] [PULL 01/10] memory: allow destroying a non-empty MemoryRegion Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 02/10] hw: do not pass NULL to memory_region_init from instance_init Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 03/10] macio: move DBDMA_init from instance_init to realize Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 04/10] tests: Fix how qom-test is run Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 05/10] libqtest: Clean up unused QTestState member sigact_old Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 06/10] libqtest: New hmp() & friends Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 07/10] device-introspect-test: New, covering device introspection Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 08/10] qmp: Fix device-list-properties not to crash for abstract device Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 09/10] qdev: Protect device-list-properties against broken devices Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 10/10] Revert "qdev: Use qdev_get_device_class() for -device <type>, help" Markus Armbruster
2015-10-04 21:24 ` [Qemu-devel] [PULL 00/10] Fix device introspection regressions Peter Maydell
2015-10-05  6:49   ` Markus Armbruster
2015-10-05 11:55     ` Peter Maydell
2015-10-05 17:11       ` Markus Armbruster
2015-10-05 18:46         ` Peter Maydell
2015-10-05 19:27           ` Paolo Bonzini
2015-10-05 19:37             ` Peter Maydell
2015-10-06  5:46               ` Markus Armbruster
2015-10-06  8:05                 ` Peter Maydell
2015-10-06  8:45                   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443806441-23519-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).