[Qemu-devel] [PATCH] target-tilegx: Implement v2mults instruction

[Qemu-devel] [PATCH] target-tilegx: Implement v2mults instruction

[gang.chen.5i5j]

From: Chen Gang <gang.chen.5i5j@gmail.com>

Just according to v1multu instruction implementation.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 target-tilegx/helper.h      |  1 +
 target-tilegx/simd_helper.c | 13 +++++++++++++
 target-tilegx/translate.c   |  5 +++++
 3 files changed, 19 insertions(+)

diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
index 3f4fa3c..ff280ac 100644
--- a/target-tilegx/helper.h
+++ b/target-tilegx/helper.h
@@ -16,6 +16,7 @@ DEF_HELPER_FLAGS_2(v2int_h, TCG_CALL_NO_RWG_SE, i64, i64, i64)
 DEF_HELPER_FLAGS_2(v2int_l, TCG_CALL_NO_RWG_SE, i64, i64, i64)
 
 DEF_HELPER_FLAGS_2(v1multu, TCG_CALL_NO_RWG_SE, i64, i64, i64)
+DEF_HELPER_FLAGS_2(v2mults, TCG_CALL_NO_RWG_SE, i64, i64, i64)
 DEF_HELPER_FLAGS_2(v1shl, TCG_CALL_NO_RWG_SE, i64, i64, i64)
 DEF_HELPER_FLAGS_2(v1shru, TCG_CALL_NO_RWG_SE, i64, i64, i64)
 DEF_HELPER_FLAGS_2(v1shrs, TCG_CALL_NO_RWG_SE, i64, i64, i64)
diff --git a/target-tilegx/simd_helper.c b/target-tilegx/simd_helper.c
index 6fa6318..4f226eb 100644
--- a/target-tilegx/simd_helper.c
+++ b/target-tilegx/simd_helper.c
@@ -41,6 +41,19 @@ uint64_t helper_v1multu(uint64_t a, uint64_t b)
     return r;
 }
 
+uint64_t helper_v2mults(uint64_t a, uint64_t b)
+{
+    uint64_t r = 0;
+    int i;
+
+    for (i = 0; i < 64; i += 16) {
+        int64_t ae = (int16_t)(a >> i);
+        int64_t be = (int16_t)(b >> i);
+        r |= ((ae * be) & 0xffff) << i;
+    }
+    return r;
+}
+
 uint64_t helper_v1shl(uint64_t a, uint64_t b)
 {
     uint64_t m;
diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
index 6853628..40f9b12 100644
--- a/target-tilegx/translate.c
+++ b/target-tilegx/translate.c
@@ -990,6 +990,7 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
         mnemonic = "fsingle_mul1";
         break;
     case OE_RRR(FSINGLE_MUL2, 0, X0):
+        tcg_gen_mov_i64(TDEST, tsrca);
         mnemonic = "fsingle_mul2";
         break;
     case OE_RRR(FSINGLE_PACK2, 0, X0):
@@ -1429,7 +1430,11 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
     case OE_RRR(V2MNZ, 0, X1):
     case OE_RRR(V2MULFSC, 0, X0):
     case OE_RRR(V2MULS, 0, X0):
+        return TILEGX_EXCP_OPCODE_UNIMPLEMENTED;
     case OE_RRR(V2MULTS, 0, X0):
+        gen_helper_v2mults(TDEST, tsrca, tsrcb);
+        mnemonic = "v2shl";
+        break;
     case OE_RRR(V2MZ, 0, X0):
     case OE_RRR(V2MZ, 0, X1):
     case OE_RRR(V2PACKH, 0, X0):
-- 
1.9.3

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v2mults instruction

[Chen Gang]

On 10/3/15 10:43, gang.chen.5i5j@gmail.com wrote:
> diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
> index 6853628..40f9b12 100644
> --- a/target-tilegx/translate.c
> +++ b/target-tilegx/translate.c
> @@ -990,6 +990,7 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
>          mnemonic = "fsingle_mul1";
>          break;
>      case OE_RRR(FSINGLE_MUL2, 0, X0):
> +        tcg_gen_mov_i64(TDEST, tsrca);

Oh, sorry, it is wast contents, needs to be deleted.

I shall send patch v2 for it.

>          mnemonic = "fsingle_mul2";
>          break;
>      case OE_RRR(FSINGLE_PACK2, 0, X0):
> @@ -1429,7 +1430,11 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
>      case OE_RRR(V2MNZ, 0, X1):
>      case OE_RRR(V2MULFSC, 0, X0):
>      case OE_RRR(V2MULS, 0, X0):
> +        return TILEGX_EXCP_OPCODE_UNIMPLEMENTED;
>      case OE_RRR(V2MULTS, 0, X0):
> +        gen_helper_v2mults(TDEST, tsrca, tsrcb);
> +        mnemonic = "v2shl";
> +        break;
>      case OE_RRR(V2MZ, 0, X0):
>      case OE_RRR(V2MZ, 0, X1):
>      case OE_RRR(V2PACKH, 0, X0):
> 

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed