From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, Bharata B Rao <bharata@linux.vnet.ibm.com>,
david@gibson.dropbear.id.au
Subject: [Qemu-devel] [RFC v0 2/2] spapr: Force gaps between DIMM's GPA
Date: Mon, 5 Oct 2015 14:05:24 +0530 [thread overview]
Message-ID: <1444034124-28747-3-git-send-email-bharata@linux.vnet.ibm.com> (raw)
In-Reply-To: <1444034124-28747-1-git-send-email-bharata@linux.vnet.ibm.com>
Mapping DIMMs non contiguously allows to workaround virtio bug reported
earlier:
http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html
In this case guest kernel doesn't allocate buffers that can cross DIMM
boundary keeping each buffer local to a DIMM.
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 2ec509b..a8526e9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2127,7 +2127,7 @@ static void spapr_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
goto out;
}
- pc_dimm_memory_plug(dev, &ms->hotplug_memory, mr, align, false, &local_err);
+ pc_dimm_memory_plug(dev, &ms->hotplug_memory, mr, align, true, &local_err);
if (local_err) {
goto out;
}
--
2.1.0
next prev parent reply other threads:[~2015-10-05 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 8:35 [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs Bharata B Rao
2015-10-05 8:35 ` [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region Bharata B Rao
2015-10-05 9:05 ` Igor Mammedov
2015-10-06 3:29 ` David Gibson
2015-10-06 8:02 ` Igor Mammedov
2015-10-05 15:24 ` Thomas Huth
2015-10-05 8:35 ` Bharata B Rao [this message]
2015-10-05 20:24 ` [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs Michael S. Tsirkin
2015-10-06 8:08 ` Igor Mammedov
2015-10-06 9:33 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444034124-28747-3-git-send-email-bharata@linux.vnet.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).