qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Drew <drjones@redhat.com>, "Stefan Hajnoczi" <stefanha@gmail.com>,
	"Gabriel L. Somlo" <somlo@cmu.edu>,
	qemu-devel@nongnu.org, "Marc Marí" <markmb@redhat.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable
Date: Mon, 05 Oct 2015 11:26:04 +0200	[thread overview]
Message-ID: <1444037164.14636.33.camel@redhat.com> (raw)
In-Reply-To: <20151002134041.GB16190@morn.lan>

On Fr, 2015-10-02 at 09:40 -0400, Kevin O'Connor wrote:
> On Fri, Oct 02, 2015 at 10:09:17AM +0200, Gerd Hoffmann wrote:
> > > - read four bytes from under the fw_cfg selector QEMU_CFG_KERNEL_SIZE
> > >   (0x0008),
> > > - if it is zero,    return -1 --> no kernel boot requested,
> > > - if it is nonzero, return  0 --> which means "top priority".
> > > 
> > > In other words, I agree with:
> > > 
> > > > -    option_rom[nb_option_roms].bootindex = 0;
> > > > +    option_rom[nb_option_roms].bootindex = 1;
> 
> The bootindex in QEMU is not visible in the firmware, so if the rest
> of patch 6 is dropped then the above should be dropped as well.
> 
> > Hmm.  That makes the boot order undefined for "qemu -kernel foo -device
> > virtio-blk,drive=bar,bootindex=1" when using an old seabios.  I don't
> > think this is a good idea.
> 
> Wouldn't that make the bootorder undefined everywhere? What does it
> mean to use -kernel and specify a bootorder?

Kernel gets priority 0, everything else what you specify (typically
configs start with bootindex=1), so the kernel gets the highest
priority.  So unless the user uses F12 to enter the boot menu and picks
something else the kernel is booted.

cheers,
  Gerd

  parent reply	other threads:[~2015-10-05  9:26 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 12:14 [Qemu-devel] QEMU fw_cfg DMA interface Marc Marí
2015-10-01 12:16 ` [Qemu-devel] [PATCH v4 0/7] " Marc Marí
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 2/7] fw_cfg DMA interface documentation Marc Marí
2015-10-01 14:41     ` Laszlo Ersek
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface Marc Marí
2015-10-01 14:36     ` Laszlo Ersek
2015-10-01 15:52       ` Marc Marí
2015-10-01 17:18       ` Peter Maydell
2015-10-01 19:20         ` Laszlo Ersek
2015-10-06 14:44     ` Stefan Hajnoczi
2015-10-06 14:53       ` Peter Maydell
2015-10-08  9:07         ` Stefan Hajnoczi
2015-10-08 10:01           ` Marc Marí
2015-10-06 14:54       ` Marc Marí
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 4/7] Enable fw_cfg DMA interface for ARM Marc Marí
2015-10-01 14:42     ` Laszlo Ersek
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 5/7] Enable fw_cfg DMA interface for x86 Marc Marí
2015-10-01 14:48     ` Laszlo Ersek
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable Marc Marí
2015-10-01 15:25     ` Laszlo Ersek
2015-10-01 16:02       ` Kevin O'Connor
2015-10-01 16:10         ` Laszlo Ersek
2015-10-01 18:15         ` Marc Marí
2015-10-02  8:16         ` Gerd Hoffmann
2015-10-02  8:24           ` Marc Marí
2015-10-02  9:01             ` Gerd Hoffmann
2015-10-02 11:47               ` Laszlo Ersek
2015-10-02 12:07                 ` Gerd Hoffmann
2015-10-02 13:25                   ` Laszlo Ersek
2015-10-02 13:30                     ` Laszlo Ersek
2015-10-03  0:05                     ` Jordan Justen
2015-10-02 13:38           ` Kevin O'Connor
2015-10-05  9:18             ` Gerd Hoffmann
2015-10-02  8:09       ` Gerd Hoffmann
2015-10-02 13:40         ` Kevin O'Connor
2015-10-02 13:50           ` Laszlo Ersek
2015-10-02 15:24           ` Daniel P. Berrange
2015-10-05  9:26           ` Gerd Hoffmann [this message]
2015-10-01 12:16   ` [Qemu-devel] [PATCH v4 7/7] fw_cfg: Define a static signature to be returned on DMA port reads Marc Marí
2015-10-01 16:07     ` Laszlo Ersek
2015-10-01 17:02       ` Kevin O'Connor
2015-10-01 17:17         ` Laszlo Ersek
2015-10-01 13:19   ` [Qemu-devel] [PATCH v4 0/7] fw_cfg DMA interface Kevin O'Connor
2015-10-01 16:03 ` [Qemu-devel] QEMU " Eric Blake
2015-10-01 16:11   ` Eric Blake
2015-10-01 16:19     ` Laszlo Ersek
2015-10-01 16:17   ` Laszlo Ersek
2015-10-01 16:21     ` Eric Blake
2015-10-01 16:34       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444037164.14636.33.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=lersek@redhat.com \
    --cc=markmb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=somlo@cmu.edu \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).