From: Andrew Jones <drjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, p.fedin@samsung.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines
Date: Tue, 6 Oct 2015 16:37:07 +0200 [thread overview]
Message-ID: <1444142228-6696-2-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1444142228-6696-1-git-send-email-drjones@redhat.com>
I'm not sure if arm_gic_common.h is supposed to be common, not
only between tcg and kvm, but also v2 and v3, but it currently
is (arm_gicv3_common.h includes it, and it's the only gic header
included by hw/arm/virt.c). If it should be the super-common
header, then it's unfortunate that the define names are too
generic. This patch doesn't help much, as it doesn't rename
anything, but it does start heading down the right path. With
it, code including the super-common header can start using more
appropriate names for a couple very gic-version-specific defines.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
include/hw/intc/arm_gic_common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/hw/intc/arm_gic_common.h b/include/hw/intc/arm_gic_common.h
index 564a72b2cf77f..299226064a30f 100644
--- a/include/hw/intc/arm_gic_common.h
+++ b/include/hw/intc/arm_gic_common.h
@@ -25,11 +25,13 @@
/* Maximum number of possible interrupts, determined by the GIC architecture */
#define GIC_MAXIRQ 1020
+#define GICV2_MAXIRQ GIC_MAXIRQ
/* First 32 are private to each CPU (SGIs and PPIs). */
#define GIC_INTERNAL 32
#define GIC_NR_SGIS 16
/* Maximum number of possible CPU interfaces, determined by GIC architecture */
#define GIC_NCPU 8
+#define GICV2_NCPU GIC_NCPU
#define MAX_NR_GROUP_PRIO 128
#define GIC_NR_APRS (MAX_NR_GROUP_PRIO / 32)
--
2.4.3
next prev parent reply other threads:[~2015-10-06 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:37 [Qemu-devel] [PATCH 0/2] hw/arm/virt: max-cpus init/check fixup Andrew Jones
2015-10-06 14:37 ` Andrew Jones [this message]
2015-10-09 16:41 ` [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines Peter Maydell
2015-10-12 6:58 ` Pavel Fedin
2015-10-06 14:37 ` [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly Andrew Jones
2015-10-09 16:45 ` Peter Maydell
2015-10-09 17:05 ` Andrew Jones
2015-10-12 7:00 ` Pavel Fedin
2015-10-12 12:07 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444142228-6696-2-git-send-email-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=afaerber@suse.de \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).