From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1ZjUGw-0001Sd-90
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 11:35:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1ZjUGt-0007Pi-Iv
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 11:35:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55203)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1ZjUGt-0007P0-Do
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 11:35:19 -0400
Message-ID: <1444145717.4059.46.camel@redhat.com>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Tue, 06 Oct 2015 09:35:17 -0600
In-Reply-To: <CAFEAcA9oApTaHZT8R_n6T=prMo-i=8hD+DqxqRJSEeMYq9TqJA@mail.gmail.com>
References: <20151005203357.310.44414.stgit@gimli.home>
	<CAFEAcA9oApTaHZT8R_n6T=prMo-i=8hD+DqxqRJSEeMYq9TqJA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/10] VFIO updates for 2015-10-05
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, David Gibson <david@gibson.dropbear.id.au>

On Tue, 2015-10-06 at 15:50 +0100, Peter Maydell wrote:
> On 5 October 2015 at 21:36, Alex Williamson <alex.williamson@redhat.com> wrote:
> > The following changes since commit c0b520dfb8890294a9f8879f4759172900585995:
> >
> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0
> >
> > for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:
> >
> >   vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 -0600)
> >
> > ----------------------------------------------------------------
> > VFIO updates 2015-10-05
> >
> >  - Change platform device IRQ setup sequence for compatibility
> >    with upcoming IRQ forwarding (Eric Auger)
> >  - Extensions to support vfio-pci devices on spapr-pci-host-bridge
> >    (David Gibson)
> >
> > ----------------------------------------------------------------
> 
> Hi. I'm afraid this fails to build with clang:
> 
> In file included from /home/petmay01/linaro/qemu-for-merges/hw/vfio/pci.c:38:
> /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-pci.h:7:26:
> error: redefinition of typedef 'VFIOGroup' is a C11 feature
> [-Werror,-Wtypedef-redefinition]
> typedef struct VFIOGroup VFIOGroup;
>                          ^
> /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-common.h:117:3:
> note: previous definition is here
> } VFIOGroup;
>   ^
> 1 error generated.

Thanks Peter.  David, can you send a replacement for that last patch?
Thanks,

Alex