From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjYQB-0006nQ-HY for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjYQ7-0008AL-BI for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:11 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:36535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjYQ7-0008AH-64 for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:07 -0400 Received: by wicgb1 with SMTP id gb1so181450320wic.1 for ; Tue, 06 Oct 2015 13:01:06 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 6 Oct 2015 22:00:54 +0200 Message-Id: <1444161658-15038-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pavel.dovgaluk@ispras.ru These are some comments I have about the record/replay code. I can integrate these in your patches myself, but I need an ack/tested-by and in some case more answers... Please take a look. Paolo Bonzini (4): replay: generalize ptimer event to bottom halves more replay fixes why is runstate_is_running needed? events doubts Makefile.objs | 2 ++ Makefile.target | 1 - cpu-exec.c | 2 +- cpus.c | 2 +- exec.c | 2 +- hw/bt/hci.c | 4 ++-- hw/core/ptimer.c | 8 ++------ include/qapi/qmp/qerror.h | 2 +- {replay => include/sysemu}/replay.h | 4 ++-- qapi/common.json | 6 +----- qemu-timer.c | 23 +++++++++-------------- replay/Makefile.objs | 11 +++++------ replay/replay-events.c | 24 +++++++++++++++--------- replay/replay-input.c | 2 +- replay/replay-internal.c | 4 ++-- replay/replay-internal.h | 2 +- replay/replay-time.c | 2 +- replay/replay.c | 2 +- stubs/Makefile.objs | 1 + {replay => stubs}/replay-user.c | 6 +----- stubs/replay.c | 10 +++++----- ui/input.c | 2 +- vl.c | 6 +++--- 23 files changed, 59 insertions(+), 69 deletions(-) rename {replay => include/sysemu}/replay.h (97%) mode change 100755 => 100644 replay/Makefile.objs mode change 100755 => 100644 replay/replay-events.c mode change 100755 => 100644 replay/replay-input.c mode change 100755 => 100644 replay/replay-internal.c mode change 100755 => 100644 replay/replay-internal.h mode change 100755 => 100644 replay/replay-time.c mode change 100755 => 100644 replay/replay.c rename {replay => stubs}/replay-user.c (90%) -- 2.5.0