From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjYQG-0006rt-Aw for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjYQA-0008CW-De for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:16 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:34907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjYQA-0008CB-8K for qemu-devel@nongnu.org; Tue, 06 Oct 2015 16:01:10 -0400 Received: by wicge5 with SMTP id ge5so183004119wic.0 for ; Tue, 06 Oct 2015 13:01:09 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 6 Oct 2015 22:00:57 +0200 Message-Id: <1444161658-15038-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1444161658-15038-1-git-send-email-pbonzini@redhat.com> References: <1444161658-15038-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pavel.dovgaluk@ispras.ru It doesn't seem correct to call it for all checkpoints, but why is it right for timerlist_run_timers? --- qemu-timer.c | 9 +++------ stubs/replay.c | 5 ----- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 3c6e4c3..f16e422 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -488,20 +488,17 @@ bool timerlist_run_timers(QEMUTimerList *timer_list) break; default: case QEMU_CLOCK_VIRTUAL: - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) - || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) { + if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) { goto out; } break; case QEMU_CLOCK_HOST: - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) - || !replay_checkpoint(CHECKPOINT_CLOCK_HOST)) { + if (!replay_checkpoint(CHECKPOINT_CLOCK_HOST)) { goto out; } break; case QEMU_CLOCK_VIRTUAL_RT: - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) - || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) { + if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) { goto out; } break; diff --git a/stubs/replay.c b/stubs/replay.c index 71fa7d5..42d01b5 100755 --- a/stubs/replay.c +++ b/stubs/replay.c @@ -22,11 +22,6 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint) return true; } -int runstate_is_running(void) -{ - abort(); -} - bool replay_events_enabled(void) { return false; -- 2.5.0