[Qemu-devel] [PATCH 4/4] events doubts

[Paolo Bonzini <pbonzini@redhat.com>]

It is not clear what separates REPLAY_ASYNC_EVENT_BH from other async
events.  It seems to be an ordering issue, but then why do input events
not have to be looked up in the queue?  It would be much simpler if they
are all handled the same way.
---
 replay/replay-events.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/replay/replay-events.c b/replay/replay-events.c
index 402f644..d6c61f6 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -203,13 +203,15 @@ static Event *replay_read_event(int checkpoint)
         return NULL;
     }
 
-    /* Events that has not to be in the queue */
+    /* Read event-specific data */
     switch (read_event_kind) {
     case REPLAY_ASYNC_EVENT_BH:
         if (read_id == -1) {
             read_id = replay_get_qword();
         }
         break;
+
+    /* Events that do not have to be in the queue - ### WHY? */
     case REPLAY_ASYNC_EVENT_INPUT:
         event = g_malloc0(sizeof(Event));
         event->event_kind = read_event_kind;
@@ -220,6 +222,7 @@ static Event *replay_read_event(int checkpoint)
         event->event_kind = read_event_kind;
         event->opaque = 0;
         return event;
+
     default:
         error_report("Unknown ID %d of replay event", read_event_kind);
         exit(1);
@@ -239,8 +242,6 @@ static Event *replay_read_event(int checkpoint)
         return NULL;
     }
 
-    /* Read event-specific data */
-
     return event;
 }
 
-- 
2.5.0