From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: haifeng.lin@huawei.com, mst@redhat.com, thibaut.collet@6wind.com,
jasowang@redhat.com, pbonzini@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v8 10/27] vhost-user: add vhost_user_requires_shm_log()
Date: Fri, 9 Oct 2015 17:17:24 +0200 [thread overview]
Message-ID: <1444403861-3240-11-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1444403861-3240-1-git-send-email-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Check if the backend has VHOST_USER_PROTOCOL_F_LOG_SHMFD feature and
require a shared log.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/virtio/vhost-user.c | 14 ++++++++++++--
include/hw/virtio/vhost-backend.h | 4 ++++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index fd4fcbf..01e51a0 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -25,9 +25,10 @@
#define VHOST_MEMORY_MAX_NREGIONS 8
#define VHOST_USER_F_PROTOCOL_FEATURES 30
-#define VHOST_USER_PROTOCOL_FEATURE_MASK 0x1ULL
-#define VHOST_USER_PROTOCOL_F_MQ 0
+#define VHOST_USER_PROTOCOL_FEATURE_MASK 0x3ULL
+#define VHOST_USER_PROTOCOL_F_MQ 0
+#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 1
typedef enum VhostUserRequest {
VHOST_USER_NONE = 0,
@@ -453,6 +454,14 @@ static int vhost_user_get_vq_index(struct vhost_dev *dev, int idx)
return idx;
}
+static bool vhost_user_requires_shm_log(struct vhost_dev *dev)
+{
+ assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER);
+
+ return virtio_has_feature(dev->protocol_features,
+ VHOST_USER_PROTOCOL_F_LOG_SHMFD);
+}
+
const VhostOps user_ops = {
.backend_type = VHOST_BACKEND_TYPE_USER,
.vhost_call = vhost_user_call,
@@ -462,4 +471,5 @@ const VhostOps user_ops = {
.vhost_backend_set_vring_enable = vhost_user_set_vring_enable,
.vhost_set_log_base = vhost_set_log_base,
+ .vhost_requires_shm_log = vhost_user_requires_shm_log,
};
diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h
index c6b688a..649766a 100644
--- a/include/hw/virtio/vhost-backend.h
+++ b/include/hw/virtio/vhost-backend.h
@@ -11,6 +11,8 @@
#ifndef VHOST_BACKEND_H_
#define VHOST_BACKEND_H_
+#include <stdbool.h>
+
typedef enum VhostBackendType {
VHOST_BACKEND_TYPE_NONE = 0,
VHOST_BACKEND_TYPE_KERNEL = 1,
@@ -28,6 +30,7 @@ typedef int (*vhost_backend_get_vq_index)(struct vhost_dev *dev, int idx);
typedef int (*vhost_backend_set_vring_enable)(struct vhost_dev *dev, int enable);
typedef int (*vhost_set_log_base_op)(struct vhost_dev *dev, uint64_t base);
+typedef bool (*vhost_requires_shm_log_op)(struct vhost_dev *dev);
typedef struct VhostOps {
VhostBackendType backend_type;
@@ -39,6 +42,7 @@ typedef struct VhostOps {
vhost_backend_set_vring_enable vhost_backend_set_vring_enable;
vhost_set_log_base_op vhost_set_log_base;
+ vhost_requires_shm_log_op vhost_requires_shm_log;
} VhostOps;
extern const VhostOps user_ops;
--
2.4.3
next prev parent reply other threads:[~2015-10-09 15:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 15:17 [Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 01/27] exec: factor out duplicate mmap code marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 02/27] configure: probe for memfd marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 03/27] linux-headers: add unistd.h marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 04/27] build-sys: split util-obj- on multi-lines marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 05/27] util: add linux-only memfd fallback marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 06/27] util: add memfd helpers marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 07/27] util: add fallback for qemu_memfd_alloc() marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 08/27] vhost: document log resizing marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 09/27] vhost: add vhost_set_log_base op marcandre.lureau
2015-10-09 15:17 ` marcandre.lureau [this message]
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 11/27] vhost: alloc shareable log marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 12/27] vhost-user: send log shm fd along with log_base marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 13/27] vhost-user: add a migration blocker marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 14/27] vhost: use a function for each call marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 15/27] vhost-user: document migration log marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 16/27] net: add trace_vhost_user_event marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 17/27] vhost user: add support of live migration marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 18/27] vhost user: add rarp sending after live migration for legacy guest marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 19/27] vhost-user: use an enum helper for features mask marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 20/27] vhost: add migration block if memfd failed marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 21/27] vhost-user-test: move wait_for_fds() out marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 22/27] vhost-user-test: remove useless static check marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 23/27] vhost-user-test: wrap server in TestServer struct marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 24/27] vhost-user-test: learn to tweak various qemu arguments marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 25/27] vhost-user-test: add live-migration test marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 26/27] vhost-user-test: check ownership during migration marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 27/27] seccomp: add memfd_create to whitelist marcandre.lureau
2015-10-09 15:21 ` Eduardo Otubo
2015-10-12 15:56 ` [Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support Thibaut Collet
2015-10-13 12:19 ` Thibaut Collet
2015-10-18 8:21 ` Michael S. Tsirkin
2015-10-19 13:22 ` Thibaut Collet
2015-10-19 15:39 ` Michael S. Tsirkin
2015-10-19 16:42 ` Thibaut Collet
2015-10-19 21:12 ` Michael S. Tsirkin
2015-10-20 6:30 ` Thibaut Collet
2015-10-20 10:21 ` Michael S. Tsirkin
2015-10-20 11:47 ` Thibaut Collet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444403861-3240-11-git-send-email-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=haifeng.lin@huawei.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).