From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: haifeng.lin@huawei.com, mst@redhat.com, thibaut.collet@6wind.com,
jasowang@redhat.com, pbonzini@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v8 16/27] net: add trace_vhost_user_event
Date: Fri, 9 Oct 2015 17:17:30 +0200 [thread overview]
Message-ID: <1444403861-3240-17-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1444403861-3240-1-git-send-email-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Replace error_report() and use tracing instead. It's not an error to get
a connection or a disconnection, so silence this and trace it instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
net/vhost-user.c | 4 ++--
trace-events | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 8f354eb..9b38431 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -15,6 +15,7 @@
#include "qemu/config-file.h"
#include "qemu/error-report.h"
#include "qmp-commands.h"
+#include "trace.h"
typedef struct VhostUserState {
NetClientState nc;
@@ -148,18 +149,17 @@ static void net_vhost_user_event(void *opaque, int event)
NET_CLIENT_OPTIONS_KIND_NIC,
MAX_QUEUE_NUM);
s = DO_UPCAST(VhostUserState, nc, ncs[0]);
+ trace_vhost_user_event(s->chr->label, event);
switch (event) {
case CHR_EVENT_OPENED:
if (vhost_user_start(queues, ncs) < 0) {
exit(1);
}
qmp_set_link(name, true, &err);
- error_report("chardev \"%s\" went up", s->chr->label);
break;
case CHR_EVENT_CLOSED:
qmp_set_link(name, true, &err);
vhost_user_stop(queues, ncs);
- error_report("chardev \"%s\" went down", s->chr->label);
break;
}
diff --git a/trace-events b/trace-events
index b813ae4..3f677d5 100644
--- a/trace-events
+++ b/trace-events
@@ -1696,3 +1696,6 @@ qcrypto_tls_creds_x509_load_cert_list(void *creds, const char *file) "TLS creds
# crypto/tlssession.c
qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const char *aclname, int endpoint) "TLS session new session=%p creds=%p hostname=%s aclname=%s endpoint=%d"
+
+# net/vhost-user.c
+vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
--
2.4.3
next prev parent reply other threads:[~2015-10-09 15:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 15:17 [Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 01/27] exec: factor out duplicate mmap code marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 02/27] configure: probe for memfd marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 03/27] linux-headers: add unistd.h marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 04/27] build-sys: split util-obj- on multi-lines marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 05/27] util: add linux-only memfd fallback marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 06/27] util: add memfd helpers marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 07/27] util: add fallback for qemu_memfd_alloc() marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 08/27] vhost: document log resizing marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 09/27] vhost: add vhost_set_log_base op marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 10/27] vhost-user: add vhost_user_requires_shm_log() marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 11/27] vhost: alloc shareable log marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 12/27] vhost-user: send log shm fd along with log_base marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 13/27] vhost-user: add a migration blocker marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 14/27] vhost: use a function for each call marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 15/27] vhost-user: document migration log marcandre.lureau
2015-10-09 15:17 ` marcandre.lureau [this message]
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 17/27] vhost user: add support of live migration marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 18/27] vhost user: add rarp sending after live migration for legacy guest marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 19/27] vhost-user: use an enum helper for features mask marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 20/27] vhost: add migration block if memfd failed marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 21/27] vhost-user-test: move wait_for_fds() out marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 22/27] vhost-user-test: remove useless static check marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 23/27] vhost-user-test: wrap server in TestServer struct marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 24/27] vhost-user-test: learn to tweak various qemu arguments marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 25/27] vhost-user-test: add live-migration test marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 26/27] vhost-user-test: check ownership during migration marcandre.lureau
2015-10-09 15:17 ` [Qemu-devel] [PATCH v8 27/27] seccomp: add memfd_create to whitelist marcandre.lureau
2015-10-09 15:21 ` Eduardo Otubo
2015-10-12 15:56 ` [Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support Thibaut Collet
2015-10-13 12:19 ` Thibaut Collet
2015-10-18 8:21 ` Michael S. Tsirkin
2015-10-19 13:22 ` Thibaut Collet
2015-10-19 15:39 ` Michael S. Tsirkin
2015-10-19 16:42 ` Thibaut Collet
2015-10-19 21:12 ` Michael S. Tsirkin
2015-10-20 6:30 ` Thibaut Collet
2015-10-20 10:21 ` Michael S. Tsirkin
2015-10-20 11:47 ` Thibaut Collet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444403861-3240-17-git-send-email-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=haifeng.lin@huawei.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).