From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zka2I-0006in-C2 for qemu-devel@nongnu.org; Fri, 09 Oct 2015 11:56:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zka2E-00052a-6K for qemu-devel@nongnu.org; Fri, 09 Oct 2015 11:56:46 -0400 From: Thomas Huth Date: Fri, 9 Oct 2015 17:56:34 +0200 Message-Id: <1444406198-6521-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/4] Small optimizations for code using g_malloc0 + memset/memcpy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org There are a couple of spots in the QEMU code which use g_malloc0, directly followed by a memset or memcpy which fill the whole allocated buffer. In this case it either does not make sense to zero the buffer via g_malloc0 first (so g_malloc should be used instead), or if the second command is a memset(..., 0, ...), then the memset does not make much sense, of course, since the buffer has already been zeroed by the g_malloc0. v2: - Switched some of the g_malloc0()s to g_new0()s where appropriate - Added Reviewed-by-s - The spapr_vscsi patch has been picked up by David already, so not sending it again Thomas Huth (4): hw/dma/pxa2xx: Remove superfluous memset hw/input/tsc210x: Remove superfluous memset tests/i44fx-test: No need for zeroing memory before memset linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup hw/dma/pxa2xx_dma.c | 3 +-- hw/input/tsc210x.c | 8 ++------ linux-user/syscall.c | 3 +-- tests/i440fx-test.c | 2 +- 4 files changed, 5 insertions(+), 11 deletions(-) -- 1.8.3.1