From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function
Date: Sun, 11 Oct 2015 11:52:59 +0800 [thread overview]
Message-ID: <1444535584-18220-28-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com>
__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method)
Function 0 is a query function. We do not support any function on root
device and only 3 functions are support for NVDIMM device,
DSM_CMD_NAMESPACE_LABEL_SIZE, DSM_CMD_GET_NAMESPACE_LABEL_DATA and
DSM_CMD_SET_NAMESPACE_LABEL_DATA, that means we currently only allow to access
device's Label Namespace
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
hw/mem/nvdimm/acpi.c | 178 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 177 insertions(+), 1 deletion(-)
diff --git a/hw/mem/nvdimm/acpi.c b/hw/mem/nvdimm/acpi.c
index 3b9399c..cb6a428 100644
--- a/hw/mem/nvdimm/acpi.c
+++ b/hw/mem/nvdimm/acpi.c
@@ -39,6 +39,22 @@ static void nfit_spa_uuid_pm(uuid_le *uuid)
memcpy(uuid, &uuid_pm, sizeof(uuid_pm));
}
+static bool dsm_is_root_uuid(uint8_t *uuid)
+{
+ uuid_le uuid_root = UUID_LE(0x2f10e7a4, 0x9e91, 0x11e4, 0x89,
+ 0xd3, 0x12, 0x3b, 0x93, 0xf7, 0x5c, 0xba);
+
+ return !memcmp(uuid, &uuid_root, sizeof(uuid_root));
+}
+
+static bool dsm_is_dimm_uuid(uint8_t *uuid)
+{
+ uuid_le uuid_dimm = UUID_LE(0x4309ac30, 0x0d11, 0x11e4, 0x91,
+ 0x91, 0x08, 0x00, 0x20, 0x0c, 0x9a, 0x66);
+
+ return !memcmp(uuid, &uuid_dimm, sizeof(uuid_dimm));
+}
+
enum {
NFIT_STRUCTURE_SPA = 0,
NFIT_STRUCTURE_MEMDEV = 1,
@@ -195,6 +211,22 @@ static uint32_t nvdimm_slot_to_dcr_index(int slot)
return nvdimm_slot_to_spa_index(slot) + 1;
}
+static NVDIMMDevice
+*get_nvdimm_device_by_handle(GSList *list, uint32_t handle)
+{
+ for (; list; list = list->next) {
+ NVDIMMDevice *nvdimm = list->data;
+ int slot = object_property_get_int(OBJECT(nvdimm), DIMM_SLOT_PROP,
+ NULL);
+
+ if (nvdimm_slot_to_handle(slot) == handle) {
+ return nvdimm;
+ }
+ }
+
+ return NULL;
+}
+
static int build_structure_spa(void *buf, NVDIMMDevice *nvdimm)
{
nfit_spa *nfit_spa;
@@ -310,6 +342,43 @@ static void build_nfit(void *fit, GSList *device_list, GArray *table_offsets,
#define NOTIFY_VALUE 0x99
+enum {
+ DSM_CMD_IMPLEMENTED = 0,
+
+ /* root device commands */
+ DSM_CMD_ARS_CAP = 1,
+ DSM_CMD_ARS_START = 2,
+ DSM_CMD_ARS_QUERY = 3,
+
+ /* per-nvdimm device commands */
+ DSM_CMD_SMART = 1,
+ DSM_CMD_SMART_THRESHOLD = 2,
+ DSM_CMD_BLOCK_NVDIMM_FLAGS = 3,
+ DSM_CMD_NAMESPACE_LABEL_SIZE = 4,
+ DSM_CMD_GET_NAMESPACE_LABEL_DATA = 5,
+ DSM_CMD_SET_NAMESPACE_LABEL_DATA = 6,
+ DSM_CMD_VENDOR_EFFECT_LOG_SIZE = 7,
+ DSM_CMD_GET_VENDOR_EFFECT_LOG = 8,
+ DSM_CMD_VENDOR_SPECIFIC = 9,
+};
+
+enum {
+ DSM_STATUS_SUCCESS = 0,
+ DSM_STATUS_NOT_SUPPORTED = 1,
+ DSM_STATUS_NON_EXISTING_MEM_DEV = 2,
+ DSM_STATUS_INVALID_PARAS = 3,
+ DSM_STATUS_VENDOR_SPECIFIC_ERROR = 4,
+};
+
+#define DSM_REVISION (1)
+
+/* do not support any command except NFIT_CMD_IMPLEMENTED on root. */
+#define ROOT_SUPPORT_CMD (1 << DSM_CMD_IMPLEMENTED)
+#define DIMM_SUPPORT_CMD ((1 << DSM_CMD_IMPLEMENTED) \
+ | (1 << DSM_CMD_NAMESPACE_LABEL_SIZE) \
+ | (1 << DSM_CMD_GET_NAMESPACE_LABEL_DATA) \
+ | (1 << DSM_CMD_SET_NAMESPACE_LABEL_DATA))
+
struct dsm_in {
uint32_t handle;
uint8_t arg0[16];
@@ -320,10 +389,19 @@ struct dsm_in {
} QEMU_PACKED;
typedef struct dsm_in dsm_in;
+struct cmd_out_implemented {
+ uint64_t cmd_list;
+};
+typedef struct cmd_out_implemented cmd_out_implemented;
+
struct dsm_out {
/* the size of buffer filled by QEMU. */
uint16_t len;
- uint8_t data[0];
+ union {
+ uint8_t data[0];
+ uint32_t status;
+ cmd_out_implemented cmd_implemented;
+ };
} QEMU_PACKED;
typedef struct dsm_out dsm_out;
@@ -334,12 +412,110 @@ static uint64_t dsm_read(void *opaque, hwaddr addr,
return 0;
}
+static void dsm_write_root(uint32_t function, dsm_in *in, dsm_out *out)
+{
+ if (function == DSM_CMD_IMPLEMENTED) {
+ out->len = sizeof(out->cmd_implemented);
+ out->cmd_implemented.cmd_list = cpu_to_le64(ROOT_SUPPORT_CMD);
+ return;
+ }
+
+ out->len = sizeof(out->status);
+ out->status = cpu_to_le32(DSM_STATUS_NOT_SUPPORTED);
+ nvdebug("Return status %#x.\n", out->status);
+}
+
+static void dsm_write_nvdimm(uint32_t handle, uint32_t function, dsm_in *in,
+ dsm_out *out)
+{
+ GSList *list = nvdimm_get_built_list();
+ NVDIMMDevice *nvdimm = get_nvdimm_device_by_handle(list, handle);
+ uint32_t status = DSM_STATUS_NON_EXISTING_MEM_DEV;
+ uint64_t cmd_list;
+
+ if (!nvdimm) {
+ out->len = sizeof(out->status);
+ goto set_status_free;
+ }
+
+ switch (function) {
+ case DSM_CMD_IMPLEMENTED:
+ cmd_list = DIMM_SUPPORT_CMD;
+ out->len = sizeof(out->cmd_implemented);
+ out->cmd_implemented.cmd_list = cpu_to_le64(cmd_list);
+ goto free;
+ default:
+ out->len = sizeof(out->status);
+ status = DSM_STATUS_NOT_SUPPORTED;
+ };
+
+ nvdebug("Return status %#x.\n", status);
+
+set_status_free:
+ out->status = cpu_to_le32(status);
+free:
+ g_slist_free(list);
+}
+
static void dsm_write(void *opaque, hwaddr addr,
uint64_t val, unsigned size)
{
+ NVDIMMState *state = opaque;
+ MemoryRegion *dsm_ram_mr;
+ dsm_in *in;
+ dsm_out *out;
+ uint32_t revision, function, handle;
+
if (val != NOTIFY_VALUE) {
fprintf(stderr, "BUG: unexepected notify value 0x%" PRIx64, val);
}
+
+ dsm_ram_mr = memory_region_find(&state->mr, state->page_size,
+ state->page_size).mr;
+ memory_region_unref(dsm_ram_mr);
+ in = memory_region_get_ram_ptr(dsm_ram_mr);
+ out = (dsm_out *)in;
+
+ revision = in->arg1;
+ function = in->arg2;
+ handle = in->handle;
+ le32_to_cpus(&revision);
+ le32_to_cpus(&function);
+ le32_to_cpus(&handle);
+
+ nvdebug("UUID " UUID_FMT ".\n", in->arg0[0], in->arg0[1], in->arg0[2],
+ in->arg0[3], in->arg0[4], in->arg0[5], in->arg0[6],
+ in->arg0[7], in->arg0[8], in->arg0[9], in->arg0[10],
+ in->arg0[11], in->arg0[12], in->arg0[13], in->arg0[14],
+ in->arg0[15]);
+ nvdebug("Revision %#x Function %#x Handler %#x.\n", revision, function,
+ handle);
+
+ if (revision != DSM_REVISION) {
+ nvdebug("Revision %#x is not supported, expect %#x.\n",
+ revision, DSM_REVISION);
+ goto exit;
+ }
+
+ if (!handle) {
+ if (!dsm_is_root_uuid(in->arg0)) {
+ nvdebug("Root UUID does not match.\n");
+ goto exit;
+ }
+
+ return dsm_write_root(function, in, out);
+ }
+
+ if (!dsm_is_dimm_uuid(in->arg0)) {
+ nvdebug("DIMM UUID does not match.\n");
+ goto exit;
+ }
+
+ return dsm_write_nvdimm(handle, function, in, out);
+
+exit:
+ out->len = sizeof(out->status);
+ out->status = cpu_to_le32(DSM_STATUS_NOT_SUPPORTED);
}
static const MemoryRegionOps dsm_ops = {
--
1.8.3.1
next prev parent reply other threads:[~2015-10-10 19:59 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 3:52 [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM Xiao Guangrong
2015-10-10 21:17 ` Dan Williams
2015-10-12 4:33 ` Xiao Guangrong
2015-10-12 16:36 ` Dan Williams
2015-10-13 3:14 ` Xiao Guangrong
2015-10-13 3:38 ` Dan Williams
2015-10-13 5:49 ` Xiao Guangrong
2015-10-13 6:36 ` Dan Williams
2015-10-14 4:03 ` Xiao Guangrong
2015-10-14 19:20 ` Dan Williams
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 01/32] acpi: add aml_derefof Xiao Guangrong
2015-10-13 12:30 ` Igor Mammedov
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 02/32] acpi: add aml_sizeof Xiao Guangrong
2015-10-13 12:33 ` Igor Mammedov
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field Xiao Guangrong
2015-10-13 12:38 ` Igor Mammedov
2015-10-13 16:36 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release Xiao Guangrong
2015-10-13 13:34 ` Igor Mammedov
2015-10-13 16:44 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 05/32] acpi: add aml_concatenate Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 06/32] acpi: add aml_object_type Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 07/32] util: introduce qemu_file_get_page_size() Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 08/32] exec: allow memory to be allocated from any kind of path Xiao Guangrong
2015-10-12 10:08 ` Michael S. Tsirkin
2015-10-13 3:31 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 09/32] exec: allow file_ram_alloc to work on file Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 10/32] hostmem-file: clean up memory allocation Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 11/32] hostmem-file: use whole file size if possible Xiao Guangrong
2015-10-13 11:50 ` Vladimir Sementsov-Ogievskiy
2015-10-13 16:53 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 12/32] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 13/32] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 14/32] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong
2015-10-12 16:43 ` Eric Blake
2015-10-13 3:32 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 15/32] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 16/32] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 17/32] dimm: abstract dimm device from pc-dimm Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 18/32] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 19/32] dimm: keep the state of the whole backend memory Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 20/32] dimm: introduce realize callback Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 21/32] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI Xiao Guangrong
2015-10-19 6:56 ` Michael S. Tsirkin
2015-10-19 7:27 ` Xiao Guangrong
2015-10-19 7:39 ` Michael S. Tsirkin
2015-10-19 7:44 ` Xiao Guangrong
2015-10-19 9:17 ` Michael S. Tsirkin
2015-10-19 9:46 ` Igor Mammedov
2015-10-19 10:01 ` Xiao Guangrong
2015-10-19 10:34 ` Michael S. Tsirkin
2015-10-19 10:42 ` Igor Mammedov
2015-10-19 17:56 ` Xiao Guangrong
2015-10-20 2:27 ` Xiao Guangrong
2015-10-19 9:18 ` Igor Mammedov
2015-10-19 10:25 ` Michael S. Tsirkin
2015-10-19 17:54 ` Xiao Guangrong
2015-10-19 21:20 ` Michael S. Tsirkin
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 23/32] nvdimm: build ACPI NFIT table Xiao Guangrong
2015-10-12 11:27 ` Michael S. Tsirkin
2015-10-13 5:13 ` Xiao Guangrong
2015-10-13 5:42 ` Michael S. Tsirkin
2015-10-13 6:06 ` Xiao Guangrong
2015-10-12 16:40 ` Dan Williams
2015-10-13 5:17 ` Xiao Guangrong
2015-10-13 6:07 ` Michael S. Tsirkin
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 24/32] nvdimm: init the address region used by DSM method Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 25/32] nvdimm: build ACPI nvdimm devices Xiao Guangrong
2015-10-13 14:39 ` Igor Mammedov
2015-10-13 17:24 ` Xiao Guangrong
2015-10-11 3:52 ` [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-10-19 6:50 ` Michael S. Tsirkin
2015-10-19 7:14 ` Xiao Guangrong
2015-10-19 7:47 ` Michael S. Tsirkin
2015-10-19 7:51 ` Xiao Guangrong
2015-10-11 3:52 ` Xiao Guangrong [this message]
2015-10-14 9:40 ` [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function Stefan Hajnoczi
2015-10-14 14:50 ` Xiao Guangrong
2015-10-14 17:06 ` Eduardo Habkost
2015-10-15 1:43 ` Xiao Guangrong
2015-10-15 15:07 ` Stefan Hajnoczi
2015-10-16 2:30 ` Xiao Guangrong
2015-10-14 9:41 ` Stefan Hajnoczi
2015-10-14 14:52 ` Xiao Guangrong
2015-10-15 15:01 ` Stefan Hajnoczi
2015-10-16 2:32 ` Xiao Guangrong
2015-10-11 3:53 ` [Qemu-devel] [PATCH v3 28/32] nvdimm: support DSM_CMD_NAMESPACE_LABEL_SIZE function Xiao Guangrong
2015-10-11 3:53 ` [Qemu-devel] [PATCH v3 29/32] nvdimm: support DSM_CMD_GET_NAMESPACE_LABEL_DATA Xiao Guangrong
2015-10-11 3:53 ` [Qemu-devel] [PATCH v3 30/32] nvdimm: support DSM_CMD_SET_NAMESPACE_LABEL_DATA Xiao Guangrong
2015-10-11 3:53 ` [Qemu-devel] [PATCH v3 31/32] nvdimm: allow using whole backend memory as pmem Xiao Guangrong
2015-10-11 3:53 ` [Qemu-devel] [PATCH v3 32/32] nvdimm: add maintain info Xiao Guangrong
2015-10-12 2:59 ` [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM Bharata B Rao
2015-10-12 3:06 ` Xiao Guangrong
2015-10-12 8:20 ` Igor Mammedov
2015-10-12 8:21 ` Xiao Guangrong
2015-10-12 11:55 ` Michael S. Tsirkin
2015-10-13 5:29 ` Xiao Guangrong
2015-10-13 5:57 ` Michael S. Tsirkin
2015-10-13 5:52 ` Xiao Guangrong
2015-10-19 6:57 ` Michael S. Tsirkin
2015-10-19 6:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444535584-18220-28-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).