* [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
@ 2015-10-12 15:12 marcandre.lureau
2015-10-12 16:01 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: marcandre.lureau @ 2015-10-12 15:12 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, david, Marc-André Lureau, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
ivshmem doesn't actually require kvm, so enable it when POSIX is
enabled. (it is required however when ioeventfd is enabled)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
default-configs/pci.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/default-configs/pci.mak b/default-configs/pci.mak
index 7e10903..f250119 100644
--- a/default-configs/pci.mak
+++ b/default-configs/pci.mak
@@ -35,5 +35,5 @@ CONFIG_SDHCI=y
CONFIG_EDU=y
CONFIG_VGA=y
CONFIG_VGA_PCI=y
-CONFIG_IVSHMEM=$(CONFIG_KVM)
+CONFIG_IVSHMEM=$(CONFIG_POSIX)
CONFIG_ROCKER=y
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
2015-10-12 15:12 [Qemu-devel] [PATCH] config: enable ivshmem on POSIX marcandre.lureau
@ 2015-10-12 16:01 ` Peter Maydell
2015-10-12 16:05 ` Marc-André Lureau
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2015-10-12 16:01 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Paolo Bonzini, Michael S. Tsirkin, QEMU Developers, David Gibson
On 12 October 2015 at 16:12, <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ivshmem doesn't actually require kvm, so enable it when POSIX is
> enabled. (it is required however when ioeventfd is enabled)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> default-configs/pci.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> index 7e10903..f250119 100644
> --- a/default-configs/pci.mak
> +++ b/default-configs/pci.mak
> @@ -35,5 +35,5 @@ CONFIG_SDHCI=y
> CONFIG_EDU=y
> CONFIG_VGA=y
> CONFIG_VGA_PCI=y
> -CONFIG_IVSHMEM=$(CONFIG_KVM)
> +CONFIG_IVSHMEM=$(CONFIG_POSIX)
> CONFIG_ROCKER=y
I did a quick test of an OSX build with this change and
you'll be pleased to know it builds ok, no new compile
warnings :-)
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
2015-10-12 16:01 ` Peter Maydell
@ 2015-10-12 16:05 ` Marc-André Lureau
2015-10-12 16:19 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Marc-André Lureau @ 2015-10-12 16:05 UTC (permalink / raw)
To: Peter Maydell
Cc: Marc-André Lureau, David Gibson, Michael S. Tsirkin,
QEMU Developers, Paolo Bonzini
Hi Peter
----- Original Message -----
> On 12 October 2015 at 16:12, <marcandre.lureau@redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > ivshmem doesn't actually require kvm, so enable it when POSIX is
> > enabled. (it is required however when ioeventfd is enabled)
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > default-configs/pci.mak | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> > index 7e10903..f250119 100644
> > --- a/default-configs/pci.mak
> > +++ b/default-configs/pci.mak
> > @@ -35,5 +35,5 @@ CONFIG_SDHCI=y
> > CONFIG_EDU=y
> > CONFIG_VGA=y
> > CONFIG_VGA_PCI=y
> > -CONFIG_IVSHMEM=$(CONFIG_KVM)
> > +CONFIG_IVSHMEM=$(CONFIG_POSIX)
> > CONFIG_ROCKER=y
>
> I did a quick test of an OSX build with this change and
> you'll be pleased to know it builds ok, no new compile
> warnings :-)
Yes indeed, thanks for checking!
Can I add tested-by or do you add your signed off?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
2015-10-12 16:05 ` Marc-André Lureau
@ 2015-10-12 16:19 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2015-10-12 16:19 UTC (permalink / raw)
To: Marc-André Lureau
Cc: Marc-André Lureau, David Gibson, Michael S. Tsirkin,
QEMU Developers, Paolo Bonzini
On 12 October 2015 at 17:05, Marc-André Lureau <mlureau@redhat.com> wrote:
> Hi Peter
>
> ----- Original Message -----
>> On 12 October 2015 at 16:12, <marcandre.lureau@redhat.com> wrote:
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
>> >
>> > ivshmem doesn't actually require kvm, so enable it when POSIX is
>> > enabled. (it is required however when ioeventfd is enabled)
>> >
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> > ---
>> > default-configs/pci.mak | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
>> > index 7e10903..f250119 100644
>> > --- a/default-configs/pci.mak
>> > +++ b/default-configs/pci.mak
>> > @@ -35,5 +35,5 @@ CONFIG_SDHCI=y
>> > CONFIG_EDU=y
>> > CONFIG_VGA=y
>> > CONFIG_VGA_PCI=y
>> > -CONFIG_IVSHMEM=$(CONFIG_KVM)
>> > +CONFIG_IVSHMEM=$(CONFIG_POSIX)
>> > CONFIG_ROCKER=y
>>
>> I did a quick test of an OSX build with this change and
>> you'll be pleased to know it builds ok, no new compile
>> warnings :-)
>
> Yes indeed, thanks for checking!
>
> Can I add tested-by or do you add your signed off?
I didn't provide a tested-by tag because I didn't actually
check the functionality, just that it built.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-12 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 15:12 [Qemu-devel] [PATCH] config: enable ivshmem on POSIX marcandre.lureau
2015-10-12 16:01 ` Peter Maydell
2015-10-12 16:05 ` Marc-André Lureau
2015-10-12 16:19 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).