From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgBc-0006c5-HB for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlgBa-00019d-UW for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:56 -0400 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlgBa-00019X-Om for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:42:54 -0400 Received: by padhy16 with SMTP id hy16so158190651pad.1 for ; Mon, 12 Oct 2015 09:42:54 -0700 (PDT) Sender: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= From: marcandre.lureau@redhat.com Date: Mon, 12 Oct 2015 18:40:58 +0200 Message-Id: <1444668104-22955-5-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> References: <1444668104-22955-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL v2 04/50] ivhsmem: read do not accept more than sizeof(long) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, drjones@redhat.com, claudio.fontana@huawei.com, stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , pbonzini@redhat.com, cam@cs.ualberta.ca From: Marc-André Lureau ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index cc76989..fb53b3f 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t *buf, int size) static int ivshmem_can_receive(void * opaque) { - return 8; + return sizeof(long); } static void ivshmem_event(void *opaque, int event) -- 2.4.3