From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZluTo-0005Py-UP for qemu-devel@nongnu.org; Tue, 13 Oct 2015 03:58:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZluTl-0003Ih-PX for qemu-devel@nongnu.org; Tue, 13 Oct 2015 03:58:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZluTl-0003IS-K9 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 03:58:37 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BDADDC0C9A60 for ; Tue, 13 Oct 2015 07:58:36 +0000 (UTC) Message-ID: <1444723105.19915.31.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 13 Oct 2015 09:58:25 +0200 In-Reply-To: <20151012151001.GE14451@edamame.cdg.redhat.com> References: <1444649126-13863-1-git-send-email-cfergeau@redhat.com> <1444657431.19915.22.camel@redhat.com> <20151012151001.GE14451@edamame.cdg.redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] spice: Allow to set password even if disable-ticketing was used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org Hi, > > If there is an actual use case where switching authentication methods at > > runtime is needed we can discuss that. But we'll be doing that as > > explicit monitor command, not as side-effect of something else. > > Yeah, I'm not saying this patch is a good idea. However, there was a > silent change (by reading the commit log which introduced it, this > change is not mentioned at all, so may have been unintentional) Well, sort of. The check was mainly added to avoid set_ticket being called with sasl auth being active. And as setting the ticket only makes sense with spice auth being active (not knowing set_ticket can switch auth mode) the check added verifies we are in spice auth mode. > in > behaviour in QEMU, and this change causes breakage in existing apps > using QEMU. Undocumented behavior. > This patch only attempts to fix this regression, I'm not > saying one behaviour or the other is better. Fair enough. I still prefer to keep the current behavior. cheers, Gerd