From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlwcm-00017G-Mk for qemu-devel@nongnu.org; Tue, 13 Oct 2015 06:16:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlwcl-0006Qd-RS for qemu-devel@nongnu.org; Tue, 13 Oct 2015 06:16:04 -0400 From: Fam Zheng Date: Tue, 13 Oct 2015 18:16:15 +0800 Message-Id: <1444731375-14716-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5. block_job_cb is called by block_job_completed, which is always called in a main loop bottom half in existing block jobs. So we don't need to worry about thread-safety here. Signed-off-by: Fam Zheng --- blockdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 32b04b4..130b7fb 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2248,11 +2248,6 @@ out: static void block_job_cb(void *opaque, int ret) { - /* Note that this function may be executed from another AioContext besides - * the QEMU main loop. If you need to access anything that assumes the - * QEMU global mutex, use a BH or introduce a mutex. - */ - BlockDriverState *bs = opaque; const char *msg = NULL; -- 2.6.1