From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlyWf-0001Zd-GR for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:17:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlyWa-0005WD-0X for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:17:53 -0400 From: Kevin Wolf Date: Tue, 13 Oct 2015 14:17:40 +0200 Message-Id: <1444738660-18285-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1444738660-18285-1-git-send-email-kwolf@redhat.com> References: <1444738660-18285-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] blkverify: Fix BDS leak in .bdrv_open error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org Signed-off-by: Kevin Wolf --- block/blkverify.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/blkverify.c b/block/blkverify.c index f8655ad..c5f8e8d 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -143,6 +143,9 @@ static int blkverify_open(BlockDriverState *bs, QDict *options, int flags, ret = 0; fail: + if (ret < 0) { + bdrv_unref_child(bs, bs->file); + } qemu_opts_del(opts); return ret; } -- 1.8.3.1