qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de,
	qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 3/9] s390x/kvm: Fix vector validity bit in device machine checks
Date: Wed, 14 Oct 2015 13:51:41 +0200	[thread overview]
Message-ID: <1444823507-7267-4-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1444823507-7267-1-git-send-email-cornelia.huck@de.ibm.com>

From: Christian Borntraeger <borntraeger@de.ibm.com>

Device hotplugs trigger a crw machine check. All machine checks
have validity bits for certain register types. With vector support
we also have to claim that vector registers are valid.
This is a band-aid suitable for stable. Long term we should
create the full  mcic value dynamically depending on the active
features in the kernel interrupt handler.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 target-s390x/kvm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 5fdee1b..3184aca 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -2072,6 +2072,9 @@ void kvm_s390_crw_mchk(void)
         .u.mchk.cr14 = 1 << 28,
         .u.mchk.mcic = 0x00400f1d40330000ULL,
     };
+    if (kvm_check_extension(kvm_state, KVM_CAP_S390_VECTOR_REGISTERS)) {
+        irq.u.mchk.mcic |= 0x0000004000000000ULL;
+    }
     kvm_s390_floating_interrupt(&irq);
 }
 
-- 
2.6.1

  parent reply	other threads:[~2015-10-14 11:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 11:51 [Qemu-devel] [PATCH 0/9] Next set of s390x patches Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 1/9] util/qemu-config: fix missing machine command line options Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 2/9] s390x/virtio-ccw: fix 2.4 virtio compat Cornelia Huck
2015-10-14 11:51 ` Cornelia Huck [this message]
2015-10-14 11:51 ` [Qemu-devel] [PATCH 4/9] s390x: flagify mcic values Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 5/9] s390x: unify device reset during subsystem_reset() Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 6/9] s390x/ipl: we always have an ipl device Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 7/9] s390x: machine reset function with new ipl cpu handling Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 8/9] s390x: reset crypto only on clear reset and QEMU reset Cornelia Huck
2015-10-14 11:51 ` [Qemu-devel] [PATCH 9/9] s390x/cmma: clean up cmma reset Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444823507-7267-4-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).