From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 03/12] qga: add QGA_CONF environment variable
Date: Wed, 14 Oct 2015 15:07:56 -0500 [thread overview]
Message-ID: <1444853285-10643-4-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1444853285-10643-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Having a environment variable allows to override default configuration
path, useful for testing. Note that this can't easily be an argument,
since loading config is done before parsing the arguments.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index d8e063a..18e1e1d 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -945,10 +945,11 @@ static void config_load(GAConfig *config)
{
GError *gerr = NULL;
GKeyFile *keyfile;
+ const char *conf = g_getenv("QGA_CONF") ?: QGA_CONF_DEFAULT;
/* read system config */
keyfile = g_key_file_new();
- if (!g_key_file_load_from_file(keyfile, QGA_CONF_DEFAULT, 0, &gerr)) {
+ if (!g_key_file_load_from_file(keyfile, conf, 0, &gerr)) {
goto end;
}
if (g_key_file_has_key(keyfile, "general", "daemon", NULL)) {
--
1.9.1
next prev parent reply other threads:[~2015-10-14 20:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 20:07 [Qemu-devel] [PULL 00/12] qemu-ga patch queue Michael Roth
2015-10-14 20:07 ` [Qemu-devel] [PATCH 01/12] build: qemu-ga: add 'qemu-ga' build target for w32 Michael Roth
2015-10-14 20:07 ` [Qemu-devel] [PATCH 02/12] qga: Use g_new() & friends where that makes obvious sense Michael Roth
2015-10-14 20:07 ` Michael Roth [this message]
2015-10-14 20:07 ` [Qemu-devel] [PATCH 04/12] qga: do not override configuration verbosity Michael Roth
2015-10-14 20:07 ` [Qemu-devel] [PATCH 05/12] qtest: add a few fd-level qmp helpers Michael Roth
2015-10-14 20:07 ` [Qemu-devel] [PATCH 06/12] glib-compat: add 2.38/2.40/2.46 asserts Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 07/12] tests: add a local test for guest agent Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 08/12] qga: drop guest_file_init helper and replace it with static initializers Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 09/12] qga: guest exec functionality Michael Roth
2015-10-14 22:38 ` Eric Blake
2015-10-15 3:48 ` Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 10/12] qga: handle possible SIGPIPE in guest-file-write Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 11/12] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all() Michael Roth
2015-10-14 20:08 ` [Qemu-devel] [PATCH 12/12] qga: guest-exec simple stdin/stdout/stderr redirection Michael Roth
-- strict thread matches above, loose matches on Subject: below --
2015-10-15 16:05 [Qemu-devel] [PULL v2 00/12] qemu-ga patch queue Michael Roth
2015-10-15 16:05 ` [Qemu-devel] [PATCH 03/12] qga: add QGA_CONF environment variable Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444853285-10643-4-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).