From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmeb9-0006IC-Uf
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:13:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmeb4-0000CC-22
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:13:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51367)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmeb3-0000Bf-TC
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:13:14 -0400
Message-ID: <1444900391.24283.17.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 15 Oct 2015 11:13:11 +0200
In-Reply-To: <8761287by3.fsf@mail.parknet.co.jp>
References: <87k2qp8yxv.fsf@mail.parknet.co.jp>
	<87fv1d8ywp.fsf@mail.parknet.co.jp>
	<87bnc18yvw.fsf_-_@mail.parknet.co.jp>
	<1444837495.4467.29.camel@redhat.com>
	<87y4f56lzu.fsf@mail.parknet.co.jp>
	<1444895333.24283.7.camel@redhat.com>
	<87a8rk7d5q.fsf@mail.parknet.co.jp>
	<8761287by3.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars
 on -curses mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: qemu-devel@nongnu.org

  Hi,

> From this call paths, graphic_hw_text_update() => console_write_ch() =>
> ->text_update() path is only used for -curses mode. What do you think?

Oh, right, text mode curses update and text mode framebuffer rendering
take completely separate code paths.  Completely forgot that, I rarely
look into the curses code.  Sorry for the extra trouble.

> (E.g. qemu is going to extend to use this for other purpose?)

Unlikely.  In theory other ui frontends could support vga text mode that
way.  But text mode is a dying relic, people use either graphics or a
serial console these days, so I don't expect that to happen.

So, I still think it would be cleaner to implement the curses special
char mapping in ui/curses.c.  I can't imagine there is a noticable
performance difference.  But doing it like you did shouldn't break
things either.

cheers,
  Gerd