From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60813)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmebw-0006JG-9r
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmebr-0000V8-9a
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:14:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zmebr-0000Um-48
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:14:03 -0400
Message-ID: <1444900440.24283.18.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 15 Oct 2015 11:14:00 +0200
In-Reply-To: <87a8rk7d5q.fsf@mail.parknet.co.jp>
References: <87k2qp8yxv.fsf@mail.parknet.co.jp>
	<87fv1d8ywp.fsf@mail.parknet.co.jp>
	<87bnc18yvw.fsf_-_@mail.parknet.co.jp>
	<1444837495.4467.29.camel@redhat.com>
	<87y4f56lzu.fsf@mail.parknet.co.jp>
	<1444895333.24283.7.camel@redhat.com>
	<87a8rk7d5q.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars
 on -curses mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: qemu-devel@nongnu.org

> > Also you don't need a init function, you can simply init the array with
> > c99 initializers:
> >
> > chtype vga_to_curses[256] = {
> >     [0x04] = ACS_DIAMOND,
> >     [ ... ]
> > };
> 
> This is not possible, because ACS_* is not constant (initialized by
> reading from termcap or such).

Ah, ok.  That isn't obvious from reading the code.  Can you add a
comment please?

thanks,
  Gerd