From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn0ia-0003ht-DQ for qemu-devel@nongnu.org; Fri, 16 Oct 2015 04:50:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn0iY-00070N-Aa for qemu-devel@nongnu.org; Fri, 16 Oct 2015 04:50:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn0iY-00070D-4C for qemu-devel@nongnu.org; Fri, 16 Oct 2015 04:50:26 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id ADBB18F27A for ; Fri, 16 Oct 2015 08:50:25 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9G8oCaT010200 for ; Fri, 16 Oct 2015 04:50:24 -0400 From: Paolo Bonzini Date: Fri, 16 Oct 2015 10:49:30 +0200 Message-Id: <1444985411-17803-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1444985411-17803-1-git-send-email-pbonzini@redhat.com> References: <1444985411-17803-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 08/49] checkpatch: allow open braces on typedef lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The style here seems to be split according to the maintainer, but traditionally open braces were placed on typedef lines. Suggested-by: Peter Maydell Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b6d71ea..d51346a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1704,11 +1704,6 @@ sub process { ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); } -# ... however, open braces on typedef lines should be avoided. - if ($line =~ /^.\s*typedef\s+(enum|union|struct)(?:\s+$Ident\b)?.*[^;]$/) { - ERROR("typedefs should be separate from struct declaration\n" . $herecurr); - } - # missing space after union, struct or enum definition if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) { ERROR("missing space after $1 definition\n" . $herecurr); -- 2.5.0