From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu block <qemu-block@nongnu.org>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH v6 0/4] qapi: child add/delete support
Date: Fri, 16 Oct 2015 16:57:42 +0800 [thread overview]
Message-ID: <1444985866-12969-1-git-send-email-wency@cn.fujitsu.com> (raw)
If quorum's child is broken, we can use mirror job to replace it.
But sometimes, the user only need to remove the broken child, and
add it later when the problem is fixed.
It is based on the Kevin's bdrv_swap() related patch:
http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02152.html
ChangLog:
v6:
1. Use a single qmp command x-blockdev-change to replace x-blockdev-child-add
and x-blockdev-child-delete
v5:
1. Address Eric Blake's comments
v4:
1. drop nbd driver's implementation. We can use human-monitor-command
to do it.
2. Rename the command name.
v3:
1. Don't open BDS in bdrv_add_child(). Use the existing BDS which is
created by the QMP command blockdev-add.
2. The driver NBD can support filename, path, host:port now.
v2:
1. Use bdrv_get_device_or_node_name() instead of new function
bdrv_get_id_or_node_name()
2. Update the error message
3. Update the documents in block-core.json
Wen Congyang (4):
Add new block driver interface to add/delete a BDS's child
quorum: implement bdrv_add_child() and bdrv_del_child()
qmp: add monitor command to add/remove a child
hmp: add monitor command to add/remove a child
block.c | 56 ++++++++++++++++++++++++++++++++--
block/quorum.c | 59 ++++++++++++++++++++++++++++++++++--
blockdev.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++
hmp-commands.hx | 17 +++++++++++
hmp.c | 38 ++++++++++++++++++++++++
hmp.h | 1 +
include/block/block.h | 8 +++++
include/block/block_int.h | 5 ++++
qapi/block-core.json | 40 +++++++++++++++++++++++++
qmp-commands.hx | 50 +++++++++++++++++++++++++++++++
10 files changed, 345 insertions(+), 5 deletions(-)
--
2.4.3
next reply other threads:[~2015-10-16 8:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 8:57 Wen Congyang [this message]
2015-10-16 8:57 ` [Qemu-devel] [PATCH v6 1/4] Add new block driver interface to add/delete a BDS's child Wen Congyang
2015-10-19 11:10 ` Alberto Garcia
2015-10-16 8:57 ` [Qemu-devel] [PATCH v6 2/4] quorum: implement bdrv_add_child() and bdrv_del_child() Wen Congyang
2015-10-19 12:23 ` Alberto Garcia
2015-10-16 8:57 ` [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child Wen Congyang
2015-11-05 13:49 ` Alberto Garcia
2015-11-06 0:50 ` Wen Congyang
2015-11-09 14:42 ` Alberto Garcia
2015-11-10 7:23 ` Wen Congyang
2015-11-10 9:24 ` Markus Armbruster
2015-11-09 16:04 ` Kevin Wolf
2015-11-10 1:40 ` Wen Congyang
2015-11-13 10:25 ` Wen Congyang
2015-11-13 10:53 ` Kevin Wolf
2015-11-13 11:19 ` Wen Congyang
2015-11-13 11:42 ` Kevin Wolf
2015-10-16 8:57 ` [Qemu-devel] [PATCH v6 4/4] hmp: " Wen Congyang
2015-11-09 14:54 ` Alberto Garcia
2015-11-10 8:44 ` Wen Congyang
2015-10-30 6:11 ` [Qemu-devel] [PATCH v6 0/4] qapi: child add/delete support Wen Congyang
2015-11-13 9:28 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-11-13 9:37 ` Wen Congyang
2015-11-13 10:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444985866-12969-1-git-send-email-wency@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).