[Qemu-devel] [PULL 0/3] cocoa queue

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Nothing major here, just a few patches from John Arbuckle.

-- PMM

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)

are available in the git repository at:


  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20151016

for you to fetch changes up to 468a895bce1492cf83bb8be0d995ccdfcf4f2785:

  ui/cocoa.m: blinky mouse cursor fix (2015-10-16 11:06:19 +0100)

----------------------------------------------------------------
cocoa queue:
 * fixes for compiler warnings
 * fix mouse cursor flickering

----------------------------------------------------------------
John Arbuckle (3):
      ui/cocoa.m: eliminate normalWindow warning
      ui/cocoa.m: addRemovableDevicesMenuItems() warning fix
      ui/cocoa.m: blinky mouse cursor fix

 ui/cocoa.m | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 1/3] ui/cocoa.m: eliminate normalWindow warning

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

Eliminate this warning associated with the setting of the normalWindow's title:

ui/cocoa.m: In function '-[QemuCocoaAppController init]':
ui/cocoa.m:888:9: warning: format not a string literal and no format arguments
 [-Wformat-security]
         [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: 57057D6E-C108-4AE1-8370-E7E6855B2F2C@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index a91b8bc..4eabc11 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -874,7 +874,7 @@ QemuCocoaView *cocoaView;
             exit(1);
         }
         [normalWindow setAcceptsMouseMovedEvents:YES];
-        [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];
+        [normalWindow setTitle:@"QEMU"];
         [normalWindow setContentView:cocoaView];
 #if (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10)
         [normalWindow useOptimizedDrawing:YES];
-- 
1.9.1

[Qemu-devel] [PULL 2/3] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

Eliminate this warning associated with the addRemovableDevicesMenuItems()
function:

ui/cocoa.m:1344:13: warning: function declaration isn't a prototype
[-Wstrict-prototypes]
 static void addRemovableDevicesMenuItems()
             ^
ui/cocoa.m: In function 'addRemovableDevicesMenuItems':
ui/cocoa.m:1344:13: warning: old-style function definition [-Wold-style-definition]

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: 7B365FC2-072B-4E8D-A1D9-922C2D691A83@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 4eabc11..8db8b9f 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1353,7 +1353,7 @@ static void add_console_menu_entries(void)
 /* Make menu items for all removable devices.
  * Each device is given an 'Eject' and 'Change' menu item.
  */
-static void addRemovableDevicesMenuItems()
+static void addRemovableDevicesMenuItems(void)
 {
     NSMenu *menu;
     NSMenuItem *menuItem;
-- 
1.9.1

[Qemu-devel] [PULL 3/3] ui/cocoa.m: blinky mouse cursor fix

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

The mouse cursor can become blinky when being moved a lot. This patch fixes that
problem by issuing the redraw sooner.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: AAA87DD7-EC20-4F4B-B71E-C38461D9FCBA@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 8db8b9f..c0d6bb2 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1287,6 +1287,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
     NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 
     COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
+    graphic_hw_update(NULL);
 
     if (qemu_input_is_absolute()) {
         if (![cocoaView isAbsoluteEnabled]) {
@@ -1307,7 +1308,6 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
             [cocoaView handleEvent:event];
         }
     } while(event != nil);
-    graphic_hw_update(NULL);
     [pool release];
 }
 
-- 
1.9.1

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 16 October 2015 at 11:10, Peter Maydell <peter.maydell@linaro.org> wrote:
> Nothing major here, just a few patches from John Arbuckle.
>
> -- PMM
>
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
>
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20151016
>
> for you to fetch changes up to 468a895bce1492cf83bb8be0d995ccdfcf4f2785:
>
>   ui/cocoa.m: blinky mouse cursor fix (2015-10-16 11:06:19 +0100)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * fixes for compiler warnings
>  * fix mouse cursor flickering
>
> ----------------------------------------------------------------
> John Arbuckle (3):
>       ui/cocoa.m: eliminate normalWindow warning
>       ui/cocoa.m: addRemovableDevicesMenuItems() warning fix
>       ui/cocoa.m: blinky mouse cursor fix
>
>  ui/cocoa.m | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Cocoa patches for rc0.

The following changes since commit 299d1ea9bb56bd9f45f905125489bdd7d543a1aa:

  Merge remote-tracking branch 'remotes/yongbok/tags/mips-20171106' into staging (2017-11-06 16:13:10 +0000)

are available in the git repository at:

  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20171107

for you to fetch changes up to ef2088f9af16d3a19f5f094da160dd8ba52231a9:

  ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them (2017-11-07 10:14:14 +0000)

----------------------------------------------------------------
cocoa queue:
 * make scrolling work in GUI monitor windows
 * change ungrab to ctrl-alt-g (matching gtk)
 * pass unused ctrl-alt combos to guest

----------------------------------------------------------------
John Arbuckle (2):
      ui/cocoa.m: Make scrolling work again in GUI monitor windows
      ui/cocoa.m: move ungrab to ctrl-alt-g

Peter Maydell (1):
      ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them

 ui/cocoa.m | 135 +++++++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 86 insertions(+), 49 deletions(-)

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 7 November 2017 at 10:15, Peter Maydell <peter.maydell@linaro.org> wrote:
> Cocoa patches for rc0.
>
> The following changes since commit 299d1ea9bb56bd9f45f905125489bdd7d543a1aa:
>
>   Merge remote-tracking branch 'remotes/yongbok/tags/mips-20171106' into staging (2017-11-06 16:13:10 +0000)
>
> are available in the git repository at:
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20171107
>
> for you to fetch changes up to ef2088f9af16d3a19f5f094da160dd8ba52231a9:
>
>   ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them (2017-11-07 10:14:14 +0000)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * make scrolling work in GUI monitor windows
>  * change ungrab to ctrl-alt-g (matching gtk)
>  * pass unused ctrl-alt combos to guest
>
> ----------------------------------------------------------------
> John Arbuckle (2):
>       ui/cocoa.m: Make scrolling work again in GUI monitor windows
>       ui/cocoa.m: move ungrab to ctrl-alt-g
>
> Peter Maydell (1):
>       ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them
>
>  ui/cocoa.m | 135 +++++++++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 86 insertions(+), 49 deletions(-)

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Small set of cocoa patches to go in before hardfreeze...

-- PMM

The following changes since commit 2538039f2c26d66053426fb547e4f25e669baf62:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2016-03-18' into staging (2016-03-23 12:57:44 +0000)

are available in the git repository at:


  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20160323-1

for you to fetch changes up to aaac714f3172c5862d0494ac6dfe2cebdb2e218c:

  ui/cocoa.m: switch to QKeyCode (2016-03-23 14:29:30 +0000)

----------------------------------------------------------------
cocoa queue:
 * update cocoa UI front end to use QKeyCodes
 * fix the help menu documentation links to actually work
   (with both an installed and an uninstalled QEMU)

----------------------------------------------------------------
John Arbuckle (3):
      ui/cocoa.m: fix help menus
      qapi-schema.json: Add power and keypad equal keys
      ui/cocoa.m: switch to QKeyCode

 qapi-schema.json |   3 +-
 ui/cocoa.m       | 348 +++++++++++++++++++++++++++----------------------------
 2 files changed, 170 insertions(+), 181 deletions(-)

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 23 March 2016 at 14:32, Peter Maydell <peter.maydell@linaro.org> wrote:
> Small set of cocoa patches to go in before hardfreeze...
>
> -- PMM
>
> The following changes since commit 2538039f2c26d66053426fb547e4f25e669baf62:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2016-03-18' into staging (2016-03-23 12:57:44 +0000)
>
> are available in the git repository at:
>
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20160323-1
>
> for you to fetch changes up to aaac714f3172c5862d0494ac6dfe2cebdb2e218c:
>
>   ui/cocoa.m: switch to QKeyCode (2016-03-23 14:29:30 +0000)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * update cocoa UI front end to use QKeyCodes
>  * fix the help menu documentation links to actually work
>    (with both an installed and an uninstalled QEMU)
>

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Flushing the cocoa queue.

The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-09-25 21:52:30 +0100)

are available in the git repository at:


  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150925-1

for you to fetch changes up to 365d7f3c7aacc789ead96b8eeb5ba5b0a8d93d48:

  ui/cocoa.m: remove open dialog code (2015-09-25 23:14:00 +0100)

----------------------------------------------------------------
cocoa queue:
 * fix stuck-key bug if keys were down when QEMU lost focus
 * prompt the user whether they really meant to quit
 * remove the 'open image file' dialog box we used to display
   if the user started QEMU without arguments

----------------------------------------------------------------
John Arbuckle (3):
      ui/cocoa.m: verify with user before quitting QEMU
      ui/cocoa.m: prevent stuck key situation
      ui/cocoa.m: remove open dialog code

 ui/cocoa.m | 119 +++++++++++++++++++++++++++++++++----------------------------
 1 file changed, 65 insertions(+), 54 deletions(-)

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 25 September 2015 at 23:18, Peter Maydell <peter.maydell@linaro.org> wrote:
> Flushing the cocoa queue.
>
> The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-09-25 21:52:30 +0100)
>
> are available in the git repository at:
>
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150925-1
>
> for you to fetch changes up to 365d7f3c7aacc789ead96b8eeb5ba5b0a8d93d48:
>
>   ui/cocoa.m: remove open dialog code (2015-09-25 23:14:00 +0100)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * fix stuck-key bug if keys were down when QEMU lost focus
>  * prompt the user whether they really meant to quit
>  * remove the 'open image file' dialog box we used to display
>    if the user started QEMU without arguments

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Slightly late drain of the cocoa queue. Should be nothing more except
bugfixes til 2.4 I think.

-- PMM

The following changes since commit 473a49460db0a90bfda046b8f3662b49f94098eb:

  q35: Re-enable FDC on pc-q35-2.3 and older (2015-06-19 09:40:35 +0100)

are available in the git repository at:

  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150619-1

for you to fetch changes up to 693a3e01af8082f855094061650311fcaf3e1269:

  ui/cocoa.m: Add machine menu items to change and eject removable drive media (2015-06-19 11:22:31 +0100)

----------------------------------------------------------------
cocoa queue:
 * Add Machine menu, with entries for pause, resume, reset, power down, and
   media change and eject for removable drives

----------------------------------------------------------------
John Arbuckle (3):
      ui/cocoa.m: Add Machine menu with pause and resume menu items
      ui/cocoa.m: Add Reset and Power Down menu items to Machine menu
      ui/cocoa.m: Add machine menu items to change and eject removable drive media

 ui/cocoa.m | 240 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 237 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 19 June 2015 at 11:30, Peter Maydell <peter.maydell@linaro.org> wrote:
> Slightly late drain of the cocoa queue. Should be nothing more except
> bugfixes til 2.4 I think.
>
> -- PMM
>
> The following changes since commit 473a49460db0a90bfda046b8f3662b49f94098eb:
>
>   q35: Re-enable FDC on pc-q35-2.3 and older (2015-06-19 09:40:35 +0100)
>
> are available in the git repository at:
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150619-1
>
> for you to fetch changes up to 693a3e01af8082f855094061650311fcaf3e1269:
>
>   ui/cocoa.m: Add machine menu items to change and eject removable drive media (2015-06-19 11:22:31 +0100)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * Add Machine menu, with entries for pause, resume, reset, power down, and
>    media change and eject for removable drives
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM