[Qemu-devel] [PULL 0/3] cocoa queue

[Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

Nothing major here, just a few patches from John Arbuckle.

-- PMM

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)

are available in the git repository at:


  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20151016

for you to fetch changes up to 468a895bce1492cf83bb8be0d995ccdfcf4f2785:

  ui/cocoa.m: blinky mouse cursor fix (2015-10-16 11:06:19 +0100)

----------------------------------------------------------------
cocoa queue:
 * fixes for compiler warnings
 * fix mouse cursor flickering

----------------------------------------------------------------
John Arbuckle (3):
      ui/cocoa.m: eliminate normalWindow warning
      ui/cocoa.m: addRemovableDevicesMenuItems() warning fix
      ui/cocoa.m: blinky mouse cursor fix

 ui/cocoa.m | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 1/3] ui/cocoa.m: eliminate normalWindow warning

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

Eliminate this warning associated with the setting of the normalWindow's title:

ui/cocoa.m: In function '-[QemuCocoaAppController init]':
ui/cocoa.m:888:9: warning: format not a string literal and no format arguments
 [-Wformat-security]
         [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: 57057D6E-C108-4AE1-8370-E7E6855B2F2C@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index a91b8bc..4eabc11 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -874,7 +874,7 @@ QemuCocoaView *cocoaView;
             exit(1);
         }
         [normalWindow setAcceptsMouseMovedEvents:YES];
-        [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];
+        [normalWindow setTitle:@"QEMU"];
         [normalWindow setContentView:cocoaView];
 #if (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10)
         [normalWindow useOptimizedDrawing:YES];
-- 
1.9.1

[Qemu-devel] [PULL 2/3] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

Eliminate this warning associated with the addRemovableDevicesMenuItems()
function:

ui/cocoa.m:1344:13: warning: function declaration isn't a prototype
[-Wstrict-prototypes]
 static void addRemovableDevicesMenuItems()
             ^
ui/cocoa.m: In function 'addRemovableDevicesMenuItems':
ui/cocoa.m:1344:13: warning: old-style function definition [-Wold-style-definition]

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: 7B365FC2-072B-4E8D-A1D9-922C2D691A83@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 4eabc11..8db8b9f 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1353,7 +1353,7 @@ static void add_console_menu_entries(void)
 /* Make menu items for all removable devices.
  * Each device is given an 'Eject' and 'Change' menu item.
  */
-static void addRemovableDevicesMenuItems()
+static void addRemovableDevicesMenuItems(void)
 {
     NSMenu *menu;
     NSMenuItem *menuItem;
-- 
1.9.1

[Qemu-devel] [PULL 3/3] ui/cocoa.m: blinky mouse cursor fix

[Peter Maydell]

From: John Arbuckle <programmingkidx@gmail.com>

The mouse cursor can become blinky when being moved a lot. This patch fixes that
problem by issuing the redraw sooner.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Message-id: AAA87DD7-EC20-4F4B-B71E-C38461D9FCBA@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 8db8b9f..c0d6bb2 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1287,6 +1287,7 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
     NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];
 
     COCOA_DEBUG("qemu_cocoa: cocoa_refresh\n");
+    graphic_hw_update(NULL);
 
     if (qemu_input_is_absolute()) {
         if (![cocoaView isAbsoluteEnabled]) {
@@ -1307,7 +1308,6 @@ static void cocoa_refresh(DisplayChangeListener *dcl)
             [cocoaView handleEvent:event];
         }
     } while(event != nil);
-    graphic_hw_update(NULL);
     [pool release];
 }
 
-- 
1.9.1

Re: [Qemu-devel] [PULL 0/3] cocoa queue

[Peter Maydell]

On 16 October 2015 at 11:10, Peter Maydell <peter.maydell@linaro.org> wrote:
> Nothing major here, just a few patches from John Arbuckle.
>
> -- PMM
>
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
>
>
>   git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20151016
>
> for you to fetch changes up to 468a895bce1492cf83bb8be0d995ccdfcf4f2785:
>
>   ui/cocoa.m: blinky mouse cursor fix (2015-10-16 11:06:19 +0100)
>
> ----------------------------------------------------------------
> cocoa queue:
>  * fixes for compiler warnings
>  * fix mouse cursor flickering
>
> ----------------------------------------------------------------
> John Arbuckle (3):
>       ui/cocoa.m: eliminate normalWindow warning
>       ui/cocoa.m: addRemovableDevicesMenuItems() warning fix
>       ui/cocoa.m: blinky mouse cursor fix
>
>  ui/cocoa.m | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

-- PMM