qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v3 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end
Date: Fri, 16 Oct 2015 18:12:11 +0800	[thread overview]
Message-ID: <1444990343-25109-1-git-send-email-famz@redhat.com> (raw)

v3: Call bdrv_drain unconditionally in bdrv_drained_begin.
    Document the internal I/O implications between bdrv_drain_begin and end.

The nested aio_poll()'s in block layer has a bug that new r/w requests from
ioeventfds and nbd exports are processed, which might break the caller's
semantics (qmp_transaction) or even pointers (bdrv_reopen).

Fam Zheng (12):
  aio: Add "is_external" flag for event handlers
  nbd: Mark fd handlers client type as "external"
  dataplane: Mark host notifiers' client type as "external"
  aio: introduce aio_{disable,enable}_external
  block: Introduce "drained begin/end" API
  block: Add "drained begin/end" for transactional external snapshot
  block: Add "drained begin/end" for transactional backup
  block: Add "drained begin/end" for transactional blockdev-backup
  block: Add "drained begin/end" for internal snapshot
  block: Introduce BlockDriver.bdrv_drain callback
  qed: Implement .bdrv_drain
  tests: Add test case for aio_disable_external

 aio-posix.c                     |  9 ++++-
 aio-win32.c                     |  8 +++-
 async.c                         |  3 +-
 block.c                         |  2 +
 block/curl.c                    | 14 ++++---
 block/io.c                      | 23 +++++++++++-
 block/iscsi.c                   |  9 ++---
 block/linux-aio.c               |  5 ++-
 block/nbd-client.c              | 10 +++--
 block/nfs.c                     | 17 ++++-----
 block/qed.c                     |  7 ++++
 block/sheepdog.c                | 38 ++++++++++++-------
 block/ssh.c                     |  5 ++-
 block/win32-aio.c               |  5 ++-
 blockdev.c                      | 27 +++++++++++---
 hw/block/dataplane/virtio-blk.c |  5 ++-
 hw/scsi/virtio-scsi-dataplane.c | 22 +++++++----
 include/block/aio.h             | 39 ++++++++++++++++++++
 include/block/block.h           | 24 ++++++++++++
 include/block/block_int.h       |  8 ++++
 iohandler.c                     |  3 +-
 nbd.c                           |  4 +-
 tests/test-aio.c                | 82 ++++++++++++++++++++++++++++-------------
 23 files changed, 276 insertions(+), 93 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-10-16 10:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 10:12 Fam Zheng [this message]
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 01/12] aio: Add "is_external" flag for event handlers Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 02/12] nbd: Mark fd handlers client type as "external" Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 03/12] dataplane: Mark host notifiers' " Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 04/12] aio: introduce aio_{disable, enable}_external Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 05/12] block: Introduce "drained begin/end" API Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 06/12] block: Add "drained begin/end" for transactional external snapshot Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 07/12] block: Add "drained begin/end" for transactional backup Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 08/12] block: Add "drained begin/end" for transactional blockdev-backup Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 09/12] block: Add "drained begin/end" for internal snapshot Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 10/12] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 11/12] qed: Implement .bdrv_drain Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 12/12] tests: Add test case for aio_disable_external Fam Zheng
2015-10-18 23:34 ` [Qemu-devel] [PATCH v3 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444990343-25109-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).