qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v3 04/12] aio: introduce aio_{disable, enable}_external
Date: Fri, 16 Oct 2015 18:12:15 +0800	[thread overview]
Message-ID: <1444990343-25109-5-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1444990343-25109-1-git-send-email-famz@redhat.com>

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 aio-posix.c         |  3 ++-
 aio-win32.c         |  3 ++-
 include/block/aio.h | 37 +++++++++++++++++++++++++++++++++++++
 3 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/aio-posix.c b/aio-posix.c
index f0f9122..0467f23 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -261,7 +261,8 @@ bool aio_poll(AioContext *ctx, bool blocking)
 
     /* fill pollfds */
     QLIST_FOREACH(node, &ctx->aio_handlers, node) {
-        if (!node->deleted && node->pfd.events) {
+        if (!node->deleted && node->pfd.events
+            && aio_node_check(ctx, node->is_external)) {
             add_pollfd(node);
         }
     }
diff --git a/aio-win32.c b/aio-win32.c
index 3110d85..43c4c79 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -309,7 +309,8 @@ bool aio_poll(AioContext *ctx, bool blocking)
     /* fill fd sets */
     count = 0;
     QLIST_FOREACH(node, &ctx->aio_handlers, node) {
-        if (!node->deleted && node->io_notify) {
+        if (!node->deleted && node->io_notify
+            && aio_node_check(ctx, node->is_external)) {
             events[count++] = event_notifier_get_handle(node->e);
         }
     }
diff --git a/include/block/aio.h b/include/block/aio.h
index 12f1141..80151d1 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -122,6 +122,8 @@ struct AioContext {
 
     /* TimerLists for calling timers - one per clock type */
     QEMUTimerListGroup tlg;
+
+    int external_disable_cnt;
 };
 
 /**
@@ -375,4 +377,39 @@ static inline void aio_timer_init(AioContext *ctx,
  */
 int64_t aio_compute_timeout(AioContext *ctx);
 
+/**
+ * aio_disable_external:
+ * @ctx: the aio context
+ *
+ * Disable the furthur processing of clients.
+ */
+static inline void aio_disable_external(AioContext *ctx)
+{
+    atomic_inc(&ctx->external_disable_cnt);
+}
+
+/**
+ * aio_enable_external:
+ * @ctx: the aio context
+ *
+ * Disable the processing of external clients.
+ */
+static inline void aio_enable_external(AioContext *ctx)
+{
+    atomic_dec(&ctx->external_disable_cnt);
+}
+
+/**
+ * aio_node_check:
+ * @ctx: the aio context
+ * @is_external: Whether or not the checked node is an external event source.
+ *
+ * Check if the node's is_external flag is okey to be polled by the ctx at this
+ * moment. True means green light.
+ */
+static inline bool aio_node_check(AioContext *ctx, bool is_external)
+{
+    return !is_external || !atomic_read(&ctx->external_disable_cnt);
+}
+
 #endif
-- 
2.4.3

  parent reply	other threads:[~2015-10-16 10:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 10:12 [Qemu-devel] [PATCH v3 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 01/12] aio: Add "is_external" flag for event handlers Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 02/12] nbd: Mark fd handlers client type as "external" Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 03/12] dataplane: Mark host notifiers' " Fam Zheng
2015-10-16 10:12 ` Fam Zheng [this message]
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 05/12] block: Introduce "drained begin/end" API Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 06/12] block: Add "drained begin/end" for transactional external snapshot Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 07/12] block: Add "drained begin/end" for transactional backup Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 08/12] block: Add "drained begin/end" for transactional blockdev-backup Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 09/12] block: Add "drained begin/end" for internal snapshot Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 10/12] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 11/12] qed: Implement .bdrv_drain Fam Zheng
2015-10-16 10:12 ` [Qemu-devel] [PATCH v3 12/12] tests: Add test case for aio_disable_external Fam Zheng
2015-10-18 23:34 ` [Qemu-devel] [PATCH v3 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444990343-25109-5-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).