From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn7nV-0002ji-Rp for qemu-devel@nongnu.org; Fri, 16 Oct 2015 12:24:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn7nV-0005af-0S for qemu-devel@nongnu.org; Fri, 16 Oct 2015 12:24:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn7nU-0005aS-Rp for qemu-devel@nongnu.org; Fri, 16 Oct 2015 12:24:00 -0400 From: Eduardo Habkost Date: Fri, 16 Oct 2015 13:23:35 -0300 Message-Id: <1445012619-23772-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1445012619-23772-1-git-send-email-ehabkost@redhat.com> References: <1445012619-23772-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v2 5/9] target-i386: Optimize setting dr[0-3] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson From: Richard Henderson If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/bpt_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index afa28df..0563abd 100644 --- a/target-i386/bpt_helper.c +++ b/target-i386/bpt_helper.c @@ -228,9 +228,14 @@ void helper_movl_drN_T0(CPUX86State *env, int reg, target_ulong t0) { #ifndef CONFIG_USER_ONLY if (reg < 4) { - hw_breakpoint_remove(env, reg); - env->dr[reg] = t0; - hw_breakpoint_insert(env, reg); + if (hw_breakpoint_enabled(env->dr[7], reg) + && hw_breakpoint_type(env->dr[7], reg) != DR7_TYPE_IO_RW) { + hw_breakpoint_remove(env, reg); + env->dr[reg] = t0; + hw_breakpoint_insert(env, reg); + } else { + env->dr[reg] = t0; + } } else if (reg == 7) { cpu_x86_update_dr7(env, t0); } else { -- 2.1.0